Repository navigation
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. What this changesThe PR displays sanitized Gateway error explanations in failed chat status entries. Example: A lifecycle error contains data.error stating that provider:nvidia-inference has an unavailable secret reference.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Blocked before merge - 1 item remains This PR addresses a concrete omission still present on main, with a focused change in the existing mapper and no actionable introduced defect found. Priority: P2 Before merge
FindingsNone. Tests
Agent review detailsHow this fits togetherGateway broadcasts become AgentEventInfo objects, which the chat mapper converts into timeline events; the reducer turns errors into status entries rendered by native chat. flowchart LR
A[Gateway broadcast] --> B[Gateway client]
B --> C[ChatEventMapper]
C --> D[ChatConversationState]
D --> E[ChatTimelineReducer]
E --> F[Native chat status]
Technical reviewBest possible solution: Keep error resolution in ChatEventMapper, preserve existing fallbacks, and sanitize newly displayed Gateway explanations. Do we have a high-confidence way to reproduce the issue? An admitted lifecycle or job error with a string data.error and no summary demonstrably loses its explanation on main; the screenshot does not establish the payload of the reported later failures. Is this the best way to solve the issue? This is a proportionate fix at the authoritative mapping owner: it retains summary precedence and fallback behavior without adding state, transport changes, or another presentation path. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against e4a92c81e7ea. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. Review metrics
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 5, 2026, 1:51 PM ET / 18:51 UTC. |
PR cleanup reviewReviewed head: The underlying fix is still needed: current main does not read data.error for lifecycle or job failures, even after the recent chat work. The mapper change is small and the redaction regression is useful. The committed screenshot shows the old generic error, not the changed behavior. Please refresh this onto the current ChatEventMapper without replacing the newer thinking/tool mapping, and attach current-head visible proof plus focused and required test results. This looks like a good small follow-up, not a superseded PR. Action in this cleanup pass: leaving this PR open. No branch changes or runtime-proof waiver. The findings above come from source, discussion and recorded-CI review; Windows validation was not rerun in this pass. |
A failed run reports its reason twice: on the lifecycle (or job) error event and again on the terminal chat frame. With the lifecycle reason now shown, skip the chat frame's status when it repeats the same reason for the same run. A different terminal error is still shown. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Lifecycle and job failure explanations now get the same display redaction and length cap as the terminal chat frame's error text, on top of the log redaction, so bare provider keys and hosts are hidden in either path. Adds tests for a bare key, a redacted URL in both arrival orders. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
1bcfaa5 to
273a9f4
Compare
What Problem This Solves
Fixes: Windows chat shows a generic “Agent error” status for a failed turn even when its Gateway event contains an explanation.
User Impact
User impact: Chat shows the Gateway’s explanation, such as a missing provider secret reference, so users can diagnose the failure. Newly displayed
data.errortext is redacted before display.Why This Change Was Made
The mapper previously read
summaryordata.messageand fell back to “Agent error”; the Gateway reports these failures indata.error. The existing fallback remains for events without a usable explanation.Evidence
Change Type
Scope
winnodeRequired proof pools
windows-winui-interactive: confirm the explanation appears in the native chat UI on an interactive Windows host.Validation
dotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restore --filter 'FullyQualifiedName~ChatEventMapperTests|FullyQualifiedName~AgentEvent_LifecycleError_AppendsErrorStatusEntry': 17 passed on commit5c42800a.dotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --no-restorewithOPENCLAW_REPO_ROOTset to this checkout: 4,925 passed, 26 skipped, 1 failed on code commit5c42800a. The remaining folder-admission test needs Windows symlink privilege unavailable on this host.dotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restore: 5,065 passed, 1 failed on commit5c42800a. The prerequisite test failed because the Windows SDK is absent..\build.ps1: blocked by missing Windows SDK and Visual Studio C++ redistributable tooling. Documentation validation passed (72 Markdown files).git diff --check: passed.5c42800a: no required findings. Review noted that native UI proof remains pending.Real Behavior Proof
1bcfaa51; code tested at5c42800a. The later commit only adds the reported screenshot.dotnet testcommand above.ChatErrorEvent; provider test asserts an error status entry.Yesfor the reported before screenshot; after screenshot pending.data.error.Security Impact
NoYesNoNoNoYes, explain the risk and mitigation: Gateway error text is newly displayed.TokenSanitizer.SanitizeLogMessageremoves common credentials, private keys, URL query strings and local identity details before rendering. Redaction is pattern based.Compatibility and Migration
YesNoNoN/AReview Conversations