Repository navigation
Conversation
Skip cross-block Markdown selection geometry until Reactor can keep idle messages off the layout path. Reuse unchanged message content, localized strings, and animation resources, and avoid unrelated rail and title-row refreshes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR disables cross-block Markdown selection and reduces repeated rendering, allocation, and layout work while chatting. Example: An assistant reply contains two paragraphs separated by a fenced code block containing Console.WriteLine(1);.
Review scores
ProductKind: Performance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this maintainer-authored PR open because it provides a distinct performance mitigation that current main does not contain. Priority: P2 Before mergeNone. Findings
Tests
Agent review detailsHow this fits togetherGateway chat content enters the native Reactor timeline, which sanitizes Markdown and renders WinUI text, code, disclosures, navigation, and progress controls. flowchart LR
Gateway[Gateway chat content] --> Timeline[Reactor chat timeline]
Timeline --> Sanitizer[Markdown sanitization]
Sanitizer --> Presentation[Markdown presentation]
Presentation --> Controls[Native WinUI controls]
Timeline --> Navigation[History and progress controls]
Technical reviewBest possible solution: Retain the focused temporary selection rollback, preserve existing nested-table presentation, and restore cross-block selection after adopting a proven released Reactor fix. Do we have a high-confidence way to reproduce the issue? Current main mounts the pinned Reactor selection host whose layout handler scans idle message content, supporting the reported mechanism; the reported typing stalls and baseline percentage were not independently reproduced. Is this the best way to solve the issue? The temporary rollback removes the identified dependency work without adding a parallel renderer, and the record-props component preserves unchanged-message reuse; the surrounding optimizations retain existing owners. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against e9423aed4ba9. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. Review metrics
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 19, 2026, 6:19 PM ET / 23:19 UTC. |
Retain list-column placement, add nested table proof, and stabilize the elapsed-clock UI test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Update on the ClawSweeper review for head
🤖 AI-authored reply via Agency Finish PR. |
Related: microsoft/microsoft-ui-reactor#1617 (Avoid idle Markdown selection layout work).
What Problem This Solves
Typing in a long conversation can stall while a reply streams. Even when nothing is selected, old messages repeatedly measure where their text could be selected.
User Impact
Text can still be selected within a Markdown block and copied with the existing copy controls. Selecting across multiple blocks is temporarily unavailable, including the message-wide accessibility text range.
Why This Change Was Made
Use native per-block selection until a released Reactor package can keep idle messages out of layout. Keep unchanged replies behind their existing content comparison, reuse localized strings and animation resources, and avoid recalculating chat navigation and window geometry on unrelated updates.
Evidence
Before the fix, cross-block Markdown selection accounted for 43.8% of sampled UI-thread stacks during typing and streaming. The post-change native tests cover code selection, stable syntax colors, list layout, table framing and language changes. No matched before/after latency trace has been collected; the baseline percentage is not a measured speedup.
Change Type
Scope
winnodeRequired proof pools
windows-winui-interactive: compare typing with chat idle and streaming; check history ticks, title-bar tab input during pane moves, and setup connector alignment.Validation
Windows x64, final pre-commit tree:
.\build.ps1: all five Debug projects and documentation checks passed.dotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --no-restore: 5,961 passed, 29 skipped, 0 failed.dotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restore: 6,842 passed, 0 failed.dotnet test .\tests\OpenClaw.Tray.UITests\OpenClaw.Tray.UITests.csproj -r win-x64 --filter 'FullyQualifiedName~ReactorMarkdown|FullyQualifiedName~ChatLayout|FullyQualifiedName~LocalizationHelperTests': 241 passed, 3 skipped, 0 failed in the isolated native host..\build.ps1 -Project WinUI -Configuration Release -DevBuild: passed. A non-Dev Release build stopped at the signed cleanup-host prerequisite; this is not signed-package proof.Real Behavior Proof
8ffe470e; the reviewed diff was fingerprint-verified immediately before committing it as91f7e26b.Security Impact
Yes, explain the risk and mitigation: N/A. Secret redaction was not cached.Compatibility and Migration
Review Conversations