Skip to content

build(deps): refresh worker types and Vitest - #34

Open
roboclaw-bot wants to merge 2 commits into
mainfrom
openclaw/deps-seven-day-telemetry-nov21
Open

roboclaw-bot wants to merge 2 commits into
mainfrom
openclaw/deps-seven-day-telemetry-nov21

Conversation

@roboclaw-bot

Copy link
Copy Markdown
Collaborator

Summary

  • Update Cloudflare Workers types from 5.20260930.1 to 5.20261114.1 and Vitest from 5.0.2 to 5.1.0. Keep the existing Vite, Rolldown, Wrangler, workerd, Node, and install-script policy.
  • Replace the Deploy workflow's four mutable action refs with the exact commits those refs already selected. No trigger, condition, permission, runtime input, or deployment command changes.

Requested by and co-authored with @vincentkoc.

Work sessions

Linked for team reference; these sessions aren’t public.

Seven-day cutoff

Pinned base: 355ff4125c44f5890c8df50884643d90d9347681. Inclusive cutoff: 2026-11-14T01:46:00Z. Every changed npm artifact's locked tarball URL and integrity match the npm registry, and all selected versions are stable and were published by the cutoff. why-is-node-running moves from the older lock's 3.2.2 (published January 2025) to Vitest 5.1.0's exact 3.2.1 requirement. No previously locked artifact is removed.

npm artifact Selected npm publication time (UTC)
@cloudflare/workers-types 5.20261114.1 2026-11-14T01:04:51.866Z
vitest 5.1.0 2026-11-02T16:12:37.770Z
@vitest/mocker 5.1.0 2026-11-02T16:12:25.567Z
@vitest/spy 5.1.0 2026-11-02T16:12:19.562Z
chai 6.3.0 2026-09-30T19:18:04.368Z
magic-string 1.4.5 2026-10-27T05:36:50.800Z
obug 3.0.0 2026-09-09T06:13:50.788Z
std-env 4.3.0 2026-09-29T12:40:32.756Z
tinybench 6.2.3 2026-11-01T15:14:20.081Z
tinyexec 1.3.1 2026-09-03T08:50:07.324Z
why-is-node-running 3.2.1 2024-10-29T17:08:48.344Z
Previous action ref Stable tag and verified commit GitHub release time (UTC)
actions/checkout@v7 v7.0.1 · 3d3c42e5aac5ba805825da76410c181273ba90b1 2026-07-20T15:10:05Z
actions/setup-node@v7 v7.1.0 · 949feb2413d6458794dcd2491c4babbbce0c15c1 2026-10-08T02:52:34Z
actions/upload-artifact@v7 v7.0.2 · cf430e030ddbb5b0abf93d22962f4752f3646cd9 2026-10-07T10:08:14Z
actions/download-artifact@v8 v8.0.2 · 9000827ccba6bdab643e8b6fd33ac0654aef8333 2026-10-07T10:09:51Z

Wrangler 4.162.0 meets the date cutoff but, like every intervening Wrangler release, introduces a prerelease Miniflare. This PR preserves the existing Wrangler and workerd verifier pins. TypeScript 7.0.2 is already the latest stable. The existing CodeQL action pin and scanning ownership are unchanged; the separate continuity/rollback handoff in #33 remains out of scope.

Validation

  • Linux, Node 24.22.1 / npm 11.19.1: offline npm ci, npm ls --all, and npm run check passed in a credential-free filesystem/network namespace. 590 tests passed in 16 files, including real local workerd and D1 coverage.
  • Wrangler dry-run passed, listing only TELEMETRY and RATE_LIMIT. The public-vocabulary release gate passed for the observed v2026.11.6 tag at 06afb10d3272cc9deaf38ca6a3b7b839d5935638.
  • actionlint and git diff --check passed. The Deploy workflow is byte-for-byte equal to the base after reversing only the 15 action-ref substitutions.
  • No live telemetry, Cloudflare operation, manual deployment dispatch, or release. A normal main merge still triggers the repository's existing workflow.

Worked on by

roboclaw-bot and others added 2 commits November 21, 2026 02:17
Pin Deploy workflow actions to the exact commits used by their previous major refs.

Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com>
Worked on by:
- @vincentkoc

Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com>
OpenClaw-Publication: 3e7e38f8-0781-4774-8a2a-0d93c1cd5a08
@clawsweeper

clawsweeper Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Nov 21, 2026
@clawsweeper

clawsweeper Bot commented Nov 21, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

This PR updates Workers types and Vitest and pins the Deploy workflow’s existing action versions to immutable commits.

Example: The Deploy workflow checks out the repository.

  • Before: It selects actions/checkout@v7 through a mutable tag.
  • After: It selects commit 3d3c42e5aac5ba805825da76410c181273ba90b1, currently selected by that tag.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused maintenance patch supported by verified upstream metadata and successful current-head installation, validation, and build checks.
Proof confidence 🐚 platinum hermit (4/6) This development-tool and action-pinning change needs no shipped user-flow demonstration; submitted validation and successful current-head CI cover installation, checks, and the Worker dry-run.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Development dependencies need periodic refresh, and mutable action tags leave future workflow execution unpinned.
Reason: The maintainer-authored direction has clear maintenance value, preserves existing behavior, and adds no new configuration or public contract.

Merge readiness

✅ Ready for maintainer review

Keep open: this maintainer-authored PR provides a focused tooling refresh absent from main, with passing current-head validation and no actionable findings.

Priority: P3
Reviewed head: c4de6a90bf19971208be680e20df7e2c99cc1312

Before merge

None.

Findings

None.

Agent review details

How this fits together

The development toolchain installs from the npm lockfile, checks and tests the telemetry Worker, and builds it for the existing gated deployment workflow.

flowchart LR
  A[Manifest and lockfile] --> B[Dependency installation]
  B --> C[Typecheck and Vitest]
  C --> D[Worker dry run]
  D --> E[Existing deployment gate]
  F[Pinned GitHub Actions] --> B
Loading

Technical review

Best possible solution:

Land the focused tooling refresh through the existing validation and deployment workflow.

Do we have a high-confidence way to reproduce the issue?

This maintenance PR reports no runtime defect to reproduce; source inspection confirms the older dependency versions and mutable action references remain on main.

Is this the best way to solve the issue?

The update is appropriately scoped: it keeps the existing toolchain, runtime pins, install policy, and workflow owners while making action selection immutable.

AGENTS.md: not found in the target repository.

Codex review notes: model internal, reasoning medium; reviewed against 355ff4125c44.

Provenance checked

  • Workers types, Vitest, and npm lockfile keeps the original intent (7388b9e: The previous refresh maintained the existing Worker development and test toolchain under Node 24; earlier tooling history also records deterministic PR installation and validation.)
  • Deploy workflow action references keeps the original intent (133ff85: The workflow separates read-only vocabulary generation and validation from constrained publication and deployment; the PR preserves those boundaries and pins the currently selected implementations.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

  • Pinned introduced diff: The complete introduced diff changes two direct development dependencies, their lockfile entries, action references, and one changelog entry; application code and persistent formats are unchanged. (package.json:21, c4de6a90bf19)
  • Workflow equivalence: Reversing the action-reference substitutions reproduces the base workflow byte for byte, preserving triggers, permissions, credentials, conditions, inputs, and deployment commands. (.github/workflows/deploy.yml:33, c4de6a90bf19)
  • Registry verification: All changed locked package versions have tarball URLs and integrity values matching npm registry metadata, publication dates before the stated cutoff, compatible declared Node engines, and no install lifecycle scripts. No package keys are removed. Python’s TLS client initially failed against the proxy certificate; curl successfully retrieved the metadata. (package-lock.json:130, c4de6a90bf19)
  • Current-head validation: The successful check job is attached to the reviewed head and records successful npm ci, npm run check, latest-release vocabulary coverage, and Wrangler dry-run steps; CodeQL checks also passed. (.github/workflows/deploy.yml:106, c4de6a90bf19)
  • Checkout pin verified: The existing v7 tag resolves directly to the pinned commit. (3d3c42e5aac5)
  • Node setup pin verified: The existing v7 tag resolves directly to the pinned commit. (949feb2413d6)

Likely related people:

  • Peter Steinberger: Raw commit 7388b9e adds package.json:24 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 7388b9e26064; files: package.json)
  • Vincent Koc: Raw commit 133ff85 adds .github/workflows/deploy.yml:35 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 133ff8562f72; files: .github/workflows/deploy.yml)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add P3: This is routine development-tool maintenance with equivalent action selections and no application behavior change.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: This is routine development-tool maintenance with equivalent action selections and no application behavior change.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 20, 2026, 9:29 PM ET / November 21, 2026, 02:29 UTC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant