Repository navigation
build(deps): refresh worker types and Vitest - #34
roboclaw-bot wants to merge 2 commits into
Conversation
Pin Deploy workflow actions to the exact commits used by their previous major refs. Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com>
Worked on by: - @vincentkoc Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com> OpenClaw-Publication: 3e7e38f8-0781-4774-8a2a-0d93c1cd5a08
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR updates Workers types and Vitest and pins the Deploy workflow’s existing action versions to immutable commits. Example: The Deploy workflow checks out the repository.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR provides a focused tooling refresh absent from main, with passing current-head validation and no actionable findings. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe development toolchain installs from the npm lockfile, checks and tests the telemetry Worker, and builds it for the existing gated deployment workflow. flowchart LR
A[Manifest and lockfile] --> B[Dependency installation]
B --> C[Typecheck and Vitest]
C --> D[Worker dry run]
D --> E[Existing deployment gate]
F[Pinned GitHub Actions] --> B
Technical reviewBest possible solution: Land the focused tooling refresh through the existing validation and deployment workflow. Do we have a high-confidence way to reproduce the issue? This maintenance PR reports no runtime defect to reproduce; source inspection confirms the older dependency versions and mutable action references remain on main. Is this the best way to solve the issue? The update is appropriately scoped: it keeps the existing toolchain, runtime pins, install policy, and workflow owners while making action selection immutable. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 355ff4125c44. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 20, 2026, 9:29 PM ET / November 21, 2026, 02:29 UTC. |
Summary
5.20260930.1to5.20261114.1and Vitest from5.0.2to5.1.0. Keep the existing Vite, Rolldown, Wrangler, workerd, Node, and install-script policy.Requested by and co-authored with @vincentkoc.
Work sessions
Linked for team reference; these sessions aren’t public.
Seven-day cutoff
Pinned base:
355ff4125c44f5890c8df50884643d90d9347681. Inclusive cutoff:2026-11-14T01:46:00Z. Every changed npm artifact's locked tarball URL and integrity match the npm registry, and all selected versions are stable and were published by the cutoff.why-is-node-runningmoves from the older lock's3.2.2(published January 2025) to Vitest 5.1.0's exact3.2.1requirement. No previously locked artifact is removed.@cloudflare/workers-types5.20261114.12026-11-14T01:04:51.866Zvitest5.1.02026-11-02T16:12:37.770Z@vitest/mocker5.1.02026-11-02T16:12:25.567Z@vitest/spy5.1.02026-11-02T16:12:19.562Zchai6.3.02026-09-30T19:18:04.368Zmagic-string1.4.52026-10-27T05:36:50.800Zobug3.0.02026-09-09T06:13:50.788Zstd-env4.3.02026-09-29T12:40:32.756Ztinybench6.2.32026-11-01T15:14:20.081Ztinyexec1.3.12026-09-03T08:50:07.324Zwhy-is-node-running3.2.12024-10-29T17:08:48.344Zactions/checkout@v7v7.0.1·3d3c42e5aac5ba805825da76410c181273ba90b12026-07-20T15:10:05Zactions/setup-node@v7v7.1.0·949feb2413d6458794dcd2491c4babbbce0c15c12026-10-08T02:52:34Zactions/upload-artifact@v7v7.0.2·cf430e030ddbb5b0abf93d22962f4752f3646cd92026-10-07T10:08:14Zactions/download-artifact@v8v8.0.2·9000827ccba6bdab643e8b6fd33ac0654aef83332026-10-07T10:09:51ZWrangler
4.162.0meets the date cutoff but, like every intervening Wrangler release, introduces a prerelease Miniflare. This PR preserves the existing Wrangler and workerd verifier pins. TypeScript7.0.2is already the latest stable. The existing CodeQL action pin and scanning ownership are unchanged; the separate continuity/rollback handoff in #33 remains out of scope.Validation
24.22.1/ npm11.19.1: offlinenpm ci,npm ls --all, andnpm run checkpassed in a credential-free filesystem/network namespace. 590 tests passed in 16 files, including real local workerd and D1 coverage.TELEMETRYandRATE_LIMIT. The public-vocabulary release gate passed for the observedv2026.11.6tag at06afb10d3272cc9deaf38ca6a3b7b839d5935638.actionlintandgit diff --checkpassed. The Deploy workflow is byte-for-byte equal to the base after reversing only the 15 action-ref substitutions.Worked on by