Repository navigation
fix(ci): publish vocabulary through verified pull requests - #35
vincentkoc wants to merge 2 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesPublish checked vocabulary updates through a retained pull request and verify the squash-merge commit before deployment. Example: A daily refresh changes data/public-vocabulary.json and src/public-vocabulary.ts.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored draft replaces the active direct-push publisher, and review found no blocking correctness or security defect. Priority: P2 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe Deploy workflow turns released OpenClaw metadata into a validated public-name vocabulary, publishes its two generated files, and deploys the checked commit to the Worker. flowchart LR
A[Stable releases] --> B[Generated vocabulary]
B --> C[Trusted checks]
C --> D[Retained candidate PR]
D --> E[Verified squash commit]
E --> F[Worker deployment]
Technical reviewBest possible solution: Retain the existing validation and deployment owners while publishing through one candidate PR and its verified squash-merge SHA. Do we have a high-confidence way to reproduce the issue? This is a workflow maintenance change; current main visibly uses direct pushes, while the supplied fixtures exercise the replacement shell with real Git and simulated GitHub responses. Is this the best way to solve the issue? The change uses the existing publisher and deployment jobs, removes the direct-push path, and verifies the checked payload against the actual squash commit. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 355ff4125c44. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 21, 2026, 1:58 AM ET / 06:58 UTC. |
Summary
Publish the checked public-vocabulary artifact through a pull request and normal expected-head squash merge. The publisher retains unmerged candidates, validates the candidate's sole source parent, exact two-file scope and payload blobs, and requires the active strict GitHub Actions
Publication merge admissionrule plus non-fast-forward protection before posting its admission status. A concurrent main advance is rejected by the server instead of publishing stale generated data.A trusted, main-only
pull_request_targetworkflow admits fresh open-PR metadata on the exact event head. It never executes candidate code; obsolete events write no status. Candidate and provenance validation remain in the publisher. After one normal merge attempt, the publisher verifies the actual PR head/base repository, merge parent, payload, reachability, and current main before passing the merge SHA to the existing deployment job.The existing discover/generate/check boundary, artifact retention, CPR pin, Cloudflare deployment, and
refresh=falserecovery path are preserved. Only the publisher and metadata gate gain admission status permission; no new credential is introduced.Validation
Production delta for the complete PR is +188/-7 lines (net +181); tests are +248/-34 (net +214), with documentation counted separately. Production growth establishes the publisher's retained-candidate, strict admission, and exact merged-receipt ownership boundary in the existing workflow/module.
Activation boundary
Draft only: merging this workflow triggers the existing production Deploy workflow. Production merge remains held pending explicit approval. No workflow dispatch, production deployment, ruleset activation, or exclusion removal was performed for this update.
Before automatic publication, an administrator must verify the default-only strict
Publication merge admissionrule from GitHub Actions App 15368 with no bypass actors. Runtime accepts redacted bypass metadata, rejects exposed bypasses, and holds the candidate if required protection is absent. The repository remains excluded from the organization PR-only rule until an actual non-noop publisher run proves PR creation, normal merge, and the deployment receipt.