Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Apply one transport policy to diagnostic info and SAI commands, including completion. Support private CA trust without disabling certificate checks, retain local plaintext diagnostics, and test the connection boundaries. Signed-off-by: Baiju Parameswaran <baijup@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: db2e0f10-3729-4d5d-b4da-3654eb856d74
Signed-off-by: Baiju Parameswaran <baijup@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: db2e0f10-3729-4d5d-b4da-3654eb856d74
611ef89 to
f99127a
Compare
|
@hardikharti can you pls check this PR? |
Reuse the Cobra and Viper dependencies supplied by the embedded libraries instead of declaring them again on the internal test targets. Keep only these dependency attributes explicit so Gazelle does not recreate the redundant entries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: db2e0f10-3729-4d5d-b4da-3654eb856d74 Signed-off-by: Baiju Parameswaran <baijup@microsoft.com>
Please fix this before we can review the changes thoroughly. |
I have requested CLA with baijup@microsoft.com with Individual CLA. Please let me know if this may be checked and approved .. Thanks |
Summary
Require verified TLS for remote
lemctl luciusdiagnostic connections whilepreserving plaintext access to the standalone daemon through literal loopback
IPs.
info,sai, and SAI completion.--tls_skip_verifywith a migration message and add--tls_ca_certfor private CA bundles without disabling certificate checks.--insecureto literal loopback IPs and numeric ports, connectingdirectly without resolver or proxy routing.
documentation update.
The standalone daemon and C++ SAI client are unchanged. This change concerns the
separately built diagnostic CLI and does not assume it is packaged in downstream
images.
Verification
Validated locally on base commit
194a7d5827d97ec637c541d46684ac206284af6f:go test -race -count=1 -timeout=3m -v ./dataplane/luciusctl/...go build ./cmd/lemctlgo vet ./dataplane/luciusctl/... ./cmd/lemctl/...bazel build //...make coveragemake test-raceFocused Bazel command:
bazel test \ //dataplane/luciusctl:luciusctl_test \ //dataplane/luciusctl/internal/transport:transport_test \ //dataplane/luciusctl/sai:sai_test \ --test_output=errors --cache_test_results=noCoverage includes trusted TLS, rejected invalid certificates and legacy options,
local plaintext operation, address boundaries, proxy avoidance, and SAI
completion. The focused Go suite explicitly uses the race detector because the
repository-wide race target excludes dataplane packages.
Disposable-server checks against the actual built CLI also passed for loopback
and isolated non-loopback targets. Baseline rejection tests failed before the
change and passed afterward. An intermediate test-source error was corrected;
the final source passed the checks above. Hosted CI results remain pending.