Repository navigation
Set the correct admin status when creating kernel and tap ports - #758
Merged
Merged
Conversation
Add admin_state to KernelPortDesc
Add admin_state to TAPPortDesc
Add code to set the admin status.
Update to set the admin status
Set admin status when creating the ports.
Add imports
Remove redundant code
Revert previously changed logic to set the admin status since pcap requires the status to be up.
Contributor
|
/gcbrun |
Added error handling for LinkSet
Fix unit test.
Contributor
|
/gcbrun |
Fix the previously changed oper status for tap ports.
Contributor
|
/gcbrun |
sonikajindal
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code creates the interfaces with a default admin status. Then send another rpc call to update the status if it is not correct. The new code sets the correct admin status when creating the interfaces.