Repository navigation
feat(saiserver): add FDB/Flood tables, VLAN flood ports, and L2 tagging - #767
Merged
hardikharti merged 1 commit intoOct 26, 2026
Merged
Conversation
Contributor
|
/gcbrun |
mohankarthik
left a comment
mohankarthik
left a comment
Contributor
There was a problem hiding this comment.
Mirroring the Chunk 3 notes from #722 (pullrequestreview-5598781722) regarding per-(port, VLAN) egress decap on hybrid ports and OBJECT_TYPE_LAG flood port expansion.
hardikharti
requested changes
Oct 22, 2026
thineshvs-google
force-pushed
the
l2-chunk3-vlan-flood-tagging
branch
from
October 22, 2026 19:05
b8df690 to
13f75ad
Compare
Contributor
|
/gcbrun |
hardikharti
approved these changes
Oct 24, 2026
mohankarthik
approved these changes
Oct 25, 2026
mohankarthik
left a comment
mohankarthik
left a comment
Contributor
There was a problem hiding this comment.
LGTM for Chunk 3 — thanks for the explanation on vlan_flood_<vid> replication inside ACTION_TYPE_OUTPUT. We will follow up on hybrid multi-VLAN port handling (#764) and targetPhysicalPorts(portID) LAG flood expansion (#766) once those PRs land. (Feel free to resolve both threads from your side, as GitHub only allows the PR author or repo maintainers to mark threads resolved.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds dataplane
FDBTableandFloodTablecreation, per-VLAN aggregate flood ports (vlan_flood_<vid>), and 802.1Q ingress/egress tagging actions for VLAN member ports (Chunk 3 of L2/VLAN/FDB support).Changes
dataplane/saiserver/switch.go:FDBTable(TABLE_TYPE_BRIDGE) andFloodTable(TABLE_TYPE_EXACTonPACKET_FIELD_NUM_VLAN_TAGwith fallback tooutputTable).VlanTabledefault action toACTION_TYPE_CONTINUEso non-VLAN ports pass through unmodified.dataplane/saiserver/ports.go:VlanTablelookup togetPreIngressPipeline()andFloodTablelookup togetL2Pipeline().CreatePortso only configured VLAN members perform 802.1Q tagging.dataplane/saiserver/routing.go&dataplane/saiserver/vlan_test.go:vlan_flood_<vid>aggregate flood port inCreateVlanand manage member membership +FloodTable(TransmitAction->BridgeLearnAction->LookupAction(FDBTable)) and egressDecapAction(ETHERNET_VLAN)inCreateVlanMember/RemoveVlanMember.binary.BigEndian.AppendUint16) forPACKET_FIELD_NUM_VLAN_TAG.