Repository navigation
feat(saiserver): implement SAI FDB entry CRUD and event pub/sub - #769
Open
thineshvs-google wants to merge 1 commit into
Open
thineshvs-google wants to merge 1 commit into
thineshvs-google wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4 of 9 for upstreaming L2 VLAN, bridge learning, and FDB support (splitting #722 into self-contained PRs under 150 LOC each; tracked in b/575886032).
Summary of Changes
dataplane/saiserver/fdb.go:subscribe,sendNotification) onfdbto broadcastFdbEventNotificationResponseevents (FDB_EVENT_LEARNED,FDB_EVENT_AGED) to active notification channels.CreateFdbEntryandCreateFdbEntriesto resolve the targetBridgePortIdOID to its physicalPortIdviaattrmgr, program the unicast MAC forwarding entry (PACKET_FIELD_NUM_ETHER_MAC_DST -> TransmitAction(portID)) into the"fdb"table, and emitFDB_EVENT_LEARNED.RemoveFdbEntryandRemoveFdbEntriesto remove the MAC entry from both the internalfwdbridge.Tablelearned-MAC cache (brTable.Remove(mac)) and the dataplane"fdb"table, and emitFDB_EVENT_AGED.dataplane/saiserver/bridge_test.go:TestCreateAndRemoveFdbEntryverifying FDB entry creation, removal, andLEARNED/AGEDnotification delivery.dataplane/saiserver/BUILD://dataplane/forwarding/fwdtable/bridgedependency tosaiserver.Testing
bazel test //dataplane/saiserver/...