Repository navigation
Cache Go module ZIP downloads through Bazel - #778
Draft
songqing-sq wants to merge 3 commits into
Draft
songqing-sq wants to merge 3 commits into
songqing-sq wants to merge 3 commits into
Conversation
Signed-off-by: 宋青 <songqing.sq@alibaba-inc.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: 宋青 <songqing.sq@alibaba-inc.com>
Signed-off-by: 宋青 <songqing.sq@alibaba-inc.com>
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Gazelle's normal Go fetch helper downloads module ZIPs outside Bazel's repository downloader. A SONiC build that consumes Lemming cannot restore those ZIPs from its Bazel repository cache or remote downloader, even with reviewed Go content checksums.
Solution
Select the ZIP-cache patch release of the current Gazelle 0.54.0 version and add a reviewed 215-module archive SHA-256 lock. Gazelle still resolves module versions and checks
h1:content digests; Bazel can now address the original archive bytes by digest. The exported plan lets the shared updater use this workspace's configured Go 1.26.6 SDK.Dependencies: SONiC Gazelle registry PR #159, which is required before this patch can use the maintained registry. Draft validation selects exact candidate
45a1ebca790a038c73353cd2417cd2df06fb1f1e; replace that temporary registry endpoint withhttps://raw.githubusercontent.com/securely1g/sonic-bazel-registry/mainand refresh the Bazel lock after the dependency merges.To update the lock from a checkout of the shared updater:
Verification
Based on current main
3fb4b7e293c13bb61a5ee85d3716c8a11e937074, native AMD64, Bazel 9.3.0 and the declared Go 1.26.6 SDK:bazel test //internal/config:config_testpassed.git diff --checkpassed.The current source build/test workflows remain selected. Native ARM64 and a complete Lemming image build were outside local validation.
Pinned SONiC consumer
Alpine PR #1 uses the minimal SONiC backport cba6977f, based on Alpine's current
1975dcc4gitlink. Its SAI/proto source trees are unchanged. The backport is included in this PR's ancestry so the existing canonical Git remote can serve that pinned commit. The current-main source tree and the validation inputs above remain unchanged.