Repository navigation
build: format the changelog that version-packages generates - #101
Merged
Merged
Conversation
The Changesets version PR (#49) failed Lint and Offline verification because the generated packages/social-sdk/CHANGELOG.md has blank lines oxfmt rejects. version-packages now runs oxfmt on the changelog it just wrote, so every regenerated version PR passes format:check. Checked in a scratch worktree from main: version-packages produces 0.6.0 and format:check passes. Refs SOC-14 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[Medium impact] The PR appears safe to merge. SummaryUpdates
Reviews (1) · Last reviewed commit: "build: format the changelog that version..." · Reviewed by Greptile |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small release-tooling change that formats only the changelog generated during package versioning, with an accompanying Changesets metadata entry. It does not alter SDK runtime behavior, production targets, schemas, or sensitive code. You can add or adjust custom eligibility rules. Learn more. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Changesets version PR #49 fails Lint and Offline verification: the
packages/social-sdk/CHANGELOG.mdthatchangeset versionwrites has extra blank lines thatoxfmtrejects.version-packagesnow formats the changelog it just generated, so every regenerated version PR passesformat:check.Evidence
packages/social-sdk/CHANGELOG.md … Format issues found, and Offline verification failed at the sameformat checkgate.After: in a scratch worktree from
main,bun run version-packagesbumps to 0.6.0, andbun run format:checkthen passes (373 files).version-packagesthroughchangesets/action, so chore: version package #49 is regenerated with the formatted changelog after this merges.Merge Danger
Door: two-way. Revert the script line.
Blast radius: release tooling only; no package code changes.
Refs SOC-14
🤖 Generated with Claude Code
Created with Claude Opus 5.5 in T3 Code.
Note
Format
packages/social-sdk/CHANGELOG.mdwithoxfmtduring versioningAdds an
oxfmtwrite step to theversion-packagesscript in package.json. It runs after Changesets updates versions and before the lockfile-only install. Includes a changeset entry at .changeset/format-version-changelog.md.Macroscope summarized 9c185cf.