Skip to content

build: format the changelog that version-packages generates - #101

Merged
leoisadev1 merged 1 commit into
mainfrom
fix/format-version-changelog
Oct 26, 2026
Merged

leoisadev1 merged 1 commit into
mainfrom
fix/format-version-changelog

Conversation

@leoisadev1

@leoisadev1 leoisadev1 commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Summary

The Changesets version PR #49 fails Lint and Offline verification: the packages/social-sdk/CHANGELOG.md that changeset version writes has extra blank lines that oxfmt rejects. version-packages now formats the changelog it just generated, so every regenerated version PR passes format:check.

-"version-packages": "changeset version && bun install --lockfile-only",
+"version-packages": "changeset version && oxfmt --write packages/social-sdk/CHANGELOG.md && bun install --lockfile-only",

Evidence

  • Before: Lint on #49 failed with packages/social-sdk/CHANGELOG.md … Format issues found, and Offline verification failed at the same format check gate.
    After: in a scratch worktree from main, bun run version-packages bumps to 0.6.0, and bun run format:check then passes (373 files).
  • The Release workflow runs version-packages through changesets/action, so chore: version package #49 is regenerated with the formatted changelog after this merges.

Merge Danger

Door: two-way. Revert the script line.

Blast radius: release tooling only; no package code changes.

Refs SOC-14

🤖 Generated with Claude Code

Created with Claude Opus 5.5 in T3 Code.


Devin Review

Note

Format packages/social-sdk/CHANGELOG.md with oxfmt during versioning

Adds an oxfmt write step to the version-packages script in package.json. It runs after Changesets updates versions and before the lockfile-only install. Includes a changeset entry at .changeset/format-version-changelog.md.

Macroscope summarized 9c185cf.

The Changesets version PR (#49) failed Lint and Offline verification
because the generated packages/social-sdk/CHANGELOG.md has blank lines
oxfmt rejects. version-packages now runs oxfmt on the changelog it just
wrote, so every regenerated version PR passes format:check. Checked in a
scratch worktree from main: version-packages produces 0.6.0 and
format:check passes.

Refs SOC-14

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 26, 2026 6:33am UTC

Request Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

Open in Capy

@greptile-apps

greptile-apps Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Updates version-packages to format the generated changelog before refreshing the lockfile.

  • Versioning formats the generated changelog before updating the lockfile.

Reviews (1) · Last reviewed commit: "build: format the changelog that version..." · Reviewed by Greptile

@macroscopeapp

macroscopeapp Bot commented Oct 26, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved at 9c185cf

Macroscope's review found this PR approvable — This is a small release-tooling change that formats only the changelog generated during package versioning, with an accompanying Changesets metadata entry. It does not alter SDK runtime behavior, production targets, schemas, or sensitive code.

You can add or adjust custom eligibility rules. Learn more.

@leoisadev1
leoisadev1 merged commit 710cb16 into main Oct 26, 2026
12 checks passed
@leoisadev1
leoisadev1 deleted the fix/format-version-changelog branch October 26, 2026 14:07

This branch was successfully deployed

1 active deployment
Preview — 9c185cf9 Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant