Repository navigation
Feature/add endpoints to update project component parameters - #91
Merged
sergio-soria-bi merged 9 commits intoOct 1, 2026
Merged
sergio-soria-bi merged 9 commits into
sergio-soria-bi merged 9 commits into
Conversation
… project component.
sergio-soria-bi
requested review from
ivan-risueno,
jordivx and
sergio-esperalta-bi
October 1, 2026 08:52
ivan-risueno
reviewed
Oct 1, 2026
| public void updateProjectComponentParameters(String projectKey, String componentId, Map<String, List<String>> requestParameters) { | ||
| var projectcomponentByProjectKeyBitbucketPathAt = provisionerActionsService.getProjectComponentBitbucketPathAt(projectKey); | ||
| var sourceCommitId = projectComponentsService.getLastCommit(projectcomponentByProjectKeyBitbucketPathAt); | ||
| var projectComponents = projectComponentsService.getProjectComponents(projectcomponentByProjectKeyBitbucketPathAt); |
Contributor
There was a problem hiding this comment.
Ensure you're retrieving cached values for better performance.
Contributor
Author
There was a problem hiding this comment.
Fair enough, fixed.
ivan-risueno
requested changes
Oct 1, 2026
ivan-risueno
requested changes
Oct 1, 2026
| items: | ||
| type: string | ||
| responses: | ||
| "200": |
Contributor
There was a problem hiding this comment.
Shouldn't it be 201 for CREATED?
ivan-risueno
approved these changes
Oct 1, 2026
|
sergio-soria-bi
deleted the
feature/add-endpoints-to-update-project-component-parameters
branch
October 1, 2026 10:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.