Skip to content

Put the document actions where the thumb is - #531

Draft
andiwand wants to merge 1 commit into
landing/08-remove-ads-in-settingsfrom
landing/09-document-action-buttons
Draft

Put the document actions where the thumb is#531
andiwand wants to merge 1 commit into
landing/08-remove-ads-in-settingsfrom
landing/09-document-action-buttons

Conversation

@andiwand

Copy link
Copy Markdown
Member

Stacked on #530.

The toolbar menu is gone. What can be done with the open document is now two buttons over its bottom right corner: search, which is what a reader reaches for most, and one that unfolds the other seven with their names next to them.

The top right corner of a modern phone is the one place a thumb holding it cannot reach, and it is where every one of these lived - four of them behind "More options", which says nothing about what is inside. Naming them costs a tap that the overflow charged anyway.

DocumentActions is a view rather than a menu, so the actions are set whenever a load finishes instead of whenever something happens to invalidate the menu. That is the reason for the odd rule the old code lived by: prepareMenu ran from onCreateMenu only, and a document that finished loading does not invalidate anything, so which items were visible depended on what else had asked the toolbar to rebuild. There is no menu provider left in either class, and menu_main.xml is deleted.

The rows scroll: seven of them do not fit above the buttons on a phone held sideways. They hide while an action mode is up - find, tts and edit each bring their own controls - and while fullscreen has the screen, which back still leaves exactly as before. Back folds them up first.

Checked on a Pixel 6 Pro emulator, portrait and landscape: unfolding, every icon, the scrim, back, the find action mode and fullscreen. All 20 instrumented tests pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RxF8q9WCwGcu5AHr9yZber

@andiwand
andiwand force-pushed the landing/09-document-action-buttons branch from d15986a to bc5ef20 Compare July 27, 2026 20:40
@andiwand
andiwand force-pushed the landing/08-remove-ads-in-settings branch 2 times, most recently from 8a3a5ad to 653c0e2 Compare July 27, 2026 22:01
@andiwand
andiwand force-pushed the landing/09-document-action-buttons branch from bc5ef20 to 7f293d8 Compare July 27, 2026 22:01
The toolbar menu is gone. What can be done with the open document is now
two buttons over its bottom right corner: search, which is what a reader
reaches for most, and one that unfolds the other seven with their names
next to them.

The top right corner of a modern phone is the one place a thumb holding
it cannot reach, and it is where every one of these lived - four of them
behind "More options", which says nothing about what is inside. Naming
them costs a tap that the overflow charged anyway.

DocumentActions is a view rather than a menu, so the actions are set
whenever a load finishes instead of whenever something happens to
invalidate the menu. That is the reason for the odd rule the old code
lived by: prepareMenu ran from onCreateMenu only, and a document that
finished loading does not invalidate anything, so which items were
visible depended on what else had asked the toolbar to rebuild. There is
no menu provider left in either class, and menu_main.xml is deleted.

The rows scroll: seven of them do not fit above the buttons on a phone
held sideways. They hide while an action mode is up - find, tts and edit
each bring their own controls - and while fullscreen has the screen,
which back still leaves exactly as before. Back folds them up first.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RxF8q9WCwGcu5AHr9yZber
@andiwand
andiwand force-pushed the landing/08-remove-ads-in-settings branch from 653c0e2 to d1dabe4 Compare July 28, 2026 07:44
@andiwand
andiwand force-pushed the landing/09-document-action-buttons branch from 7f293d8 to 7ad72b3 Compare July 28, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant