Skip to content

feat: override paragon tokens to match marketing site - #54

Closed
AmmarCodes wants to merge 5 commits into
openedx:masterfrom
zeit-labs:ammarcodes/eng-1051-build-lms-header
Closed

AmmarCodes wants to merge 5 commits into
openedx:masterfrom
zeit-labs:ammarcodes/eng-1051-build-lms-header

Conversation

@AmmarCodes

Copy link
Copy Markdown

No description provided.

The previous 'override paragon tokens to match marketing site' commit
applied the brand changes as raw --pgn-* declarations in :root and as
scoped CSS variables on .pgn__card inside core.scss. Per
docs/how-to/design-tokens-support.rst, overrides belong in
paragon/tokens/** JSON files so they flow through 'paragon build-tokens'
and become available to downstream consumers via 'paragon
replace-variables'.

Moves each override into the matching JSON:

- size.card.image.border-radius, size.card.image.vertical.max-height,
  spacing.card.margin.grid-bottom -> paragon/tokens/core/components/Card.json
- typography.badge.font.size/weight, spacing.badge.padding.x.base/y,
  size.badge.border-radius.base -> paragon/tokens/core/components/Badge.json
- size.search-field.border.width.base/focus -> paragon/tokens/core/components/SearchField.json
- color.badge.text.light, color.badge.bg.light ->
  paragon/tokens/themes/light/components/Badge.json (with 'modify: null'
  to drop the inherited color-yiq modifier so the brand hex is emitted
  verbatim instead of as #FFFFFFFF)
- typography.font.family.base -> paragon/tokens/core/global/typography.json

core.scss is reduced to non-tokenizable rules (transitions, hover
transform, raw box-shadow removals, scoped layout tweaks) plus a
comment pointing future contributors at the tokens directory.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 14, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @AmmarCodes!

This repository is currently maintained by @openedx/committers-brand-openedx.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Oct 14, 2026
@AmmarCodes AmmarCodes closed this Oct 14, 2026
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants