Skip to content

feat: Learning Sites picker (multi-instance switching UI) - #683

Merged
RawanMatar89 merged 5 commits into
openedx:developfrom
zeit-labs:infra/10-instance-picker
Sep 29, 2026
Merged

RawanMatar89 merged 5 commits into
openedx:developfrom
zeit-labs:infra/10-instance-picker

Conversation

@RawanMatar89

Copy link
Copy Markdown
Contributor

Summary

Presentation layer for multi-instance support: browse, switch, and log out of Learning Sites, with per-instance branding (logo, header image, accent color) applied app-wide.

Stacks on infra/09-app-launch-sequencing.

What's included

  • Learning Sites screen — list of logged-in and addable sites, per-site logout, switch without re-authenticating
  • Per-instance accent color — applied app-wide (buttons, links, icons), not just Sign In
  • Design pass — Learning Sites / Sign In matched to Figma, plus fixes for a wrong-instance sign-in host, a main-thread crash selecting a site, an NSCache build error, and a false "offline" status after login
  • Settings redesign — Current Learning Site card matches the mockups; log out folded into it
  • Instance-switching reliability — per-instance HEADER_BACKGROUND_URL, no stale offline banner on cold launch, no stale "downloaded" state after a user/instance switch, single-instance catalogs hide the picker entirely

Testing

  • Verified switching between multiple logged-in instances (session, theme, downloads all isolated)
  • Verified single-instance catalog collapses to a plain sign-in/logout flow

…gn-in)

- add Learning Sites list: switch sites, per-site logout, add a new site
- query/clear a specific instance's session without switching to it
- branded per-instance Sign In (logo, header image)
- route to Learning Sites instead of Sign In when there's more than one instance
- fix: Settings log out now goes through the session manager, not downloadManager directly
Accent color now updates everywhere the app uses it, not just Sign In,
using Theme.Colors/Theme.UIColors' existing update() mechanism.
Wired into instance switch, logout, and app launch.
- match Figma design for Learning Sites / Sign In, fix accent color
- fix sign-in request going to the wrong instance's host
- fix build error -- NSCache static isn't Sendable
- fix crash selecting a site -- UIKit touched off the main thread
- fix app reporting offline after a real login
- fix remaining frozen-config-value singletons
- redesign Settings / Learning Sites to match the Figma design
- fix: stale offline banner staying up after a real login
- fix: reinstalled app showing old sessions as still signed in
- fix: current site stuck selected after an abrupt relaunch
- apply accent color to buttons and icons, not just links
- apply per-instance HEADER_BACKGROUND_URL to post-login screens
- don't flash the offline banner on a cold-launch connectivity check
- stop stale downloads showing as finished after a user/instance switch
- hide single-instance UI when there's nothing to switch between
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Sep 27, 2026
@openedx-webhooks

openedx-webhooks commented Sep 27, 2026 •

Copy link
Copy Markdown

Thanks for the pull request, @RawanMatar89!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov

codecov Bot commented Sep 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (8748fc3) to head (e0ff860).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@      Coverage Diff       @@
##   develop   #683   +/-   ##
==============================
==============================

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RawanMatar89
RawanMatar89 merged commit c3c8621 into openedx:develop Sep 29, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants