Repository navigation
feat: Learning Sites picker (multi-instance switching UI) - #683
Conversation
…gn-in) - add Learning Sites list: switch sites, per-site logout, add a new site - query/clear a specific instance's session without switching to it - branded per-instance Sign In (logo, header image) - route to Learning Sites instead of Sign In when there's more than one instance - fix: Settings log out now goes through the session manager, not downloadManager directly
Accent color now updates everywhere the app uses it, not just Sign In, using Theme.Colors/Theme.UIColors' existing update() mechanism. Wired into instance switch, logout, and app launch.
- match Figma design for Learning Sites / Sign In, fix accent color - fix sign-in request going to the wrong instance's host - fix build error -- NSCache static isn't Sendable - fix crash selecting a site -- UIKit touched off the main thread - fix app reporting offline after a real login - fix remaining frozen-config-value singletons
- redesign Settings / Learning Sites to match the Figma design - fix: stale offline banner staying up after a real login - fix: reinstalled app showing old sessions as still signed in - fix: current site stuck selected after an abrupt relaunch - apply accent color to buttons and icons, not just links
- apply per-instance HEADER_BACKGROUND_URL to post-login screens - don't flash the offline banner on a cold-launch connectivity check - stop stale downloads showing as finished after a user/instance switch - hide single-instance UI when there's nothing to switch between
|
Thanks for the pull request, @RawanMatar89! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #683 +/- ##
==============================
==============================
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Presentation layer for multi-instance support: browse, switch, and log out of Learning Sites, with per-instance branding (logo, header image, accent color) applied app-wide.
Stacks on
infra/09-app-launch-sequencing.What's included
HEADER_BACKGROUND_URL, no stale offline banner on cold launch, no stale "downloaded" state after a user/instance switch, single-instance catalogs hide the picker entirelyTesting