Skip to content

feat: adapt layout for iPhone Duo - #686

Merged
IvanStepanok merged 30 commits into
openedx:developfrom
raccoongang:chore/iphone-duo-adaptation
Oct 12, 2026
Merged

IvanStepanok merged 30 commits into
openedx:developfrom
raccoongang:chore/iphone-duo-adaptation

Conversation

@Demian-Yushyn

Copy link
Copy Markdown
Contributor

On iPhone Duo the window changes size as the device opens, folds and rotates, and the system moves
the status bar and tab bar into a column at the side. The app picked its layout from the device
orientation and idiom, so on Duo the tab content collapsed to zero height, cards slid under the side
column and custom headers touched the top edge. Layout now follows the window's size classes and
safe areas, as Designing for iPhone Duo asks.

Changes

  • Size classes instead of device checks. New Core/Core/Extensions/LayoutEnvironment.swift:
    isHorizontalLayout (compact height) replaces isHorizontal in 43 files, layoutIdiom
    (regular × regular → .pad) replaces layout checks of userInterfaceIdiom in 16. iPhone and iPad
    get the same values as before; the Duo inner display gets the iPad layouts.

  • Tab bar is styled through UITabBarAppearance. The legacy isTranslucent/backgroundColor
    broke the vertical tab bar.

  • Safe areas. 15 screens no longer ignore the horizontal safe area. minimumTopSafeArea() keeps
    custom headers off the top edge when the status bar is on the side.

  • Screens without a tab bar are centred. AppNavigationController keeps the side column only on
    the main tabs and in compact height. It uses iOS 27.1 API, compiled only with an SDK that has it.

  • Scene life cycle (SceneDelegate), which iPhone Duo requires for resizable apps.

  • Course back button stays on screen when the course header collapses (scrolling down, or the
    device in landscape) and moves onto the collapsed title row, so it no longer covers the course tabs.

  • Smaller fixes: the YouTube player keeps playing through rotation and folding, Course details
    picks one or two columns from the window shape.

    Screenshots

Before → after (outer display)

Before After
Discover
Profile: content empty
Settings: cards under the status bar
Sign in: off centre
Unit: back button at the top edge
All screens: outer and inner display, portrait and landscape
Screen Outer, portrait Outer, landscape Inner, portrait Inner, landscape
Sign in
Dashboard
Discover
Profile
Edit profile
Settings
Course content
Course home
Course section
Unit: text
Unit: video

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 6, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Demian-Yushyn!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@RawanMatar89 RawanMatar89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IvanStepanok
IvanStepanok merged commit 0dac61f into openedx:develop Oct 12, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants