Skip to content

Chore/spm migration - #687

Open
Demian-Yushyn wants to merge 30 commits into
openedx:developfrom
raccoongang:chore/spm-migration
Open

Demian-Yushyn wants to merge 30 commits into
openedx:developfrom
raccoongang:chore/spm-migration

Conversation

@Demian-Yushyn

Copy link
Copy Markdown
Contributor

Summary

Migrates dependency management from CocoaPods to Swift Package Manager and adopts the UIScene life cycle.

Why

  • CocoaPods is in maintenance mode and its trunk is going read-only, so new pod versions will stop being published. SPM is Apple's native solution: no Ruby/pod install step, no generated Pods project, and dependencies resolve directly in Xcode.
  • Apps built with the iOS 27 SDK must use the UIScene life cycle. Without it, the app fails at launch with UIScene life cycle is required for apps built with this SDK.

What changed

  • Removed Podfile/Podfile.lock and the per-module .xcworkspace files; all third-party libraries are now SPM packages, pinned in the committed Package.resolved.
  • Build tools (SwiftLint, SwiftGen, Mockolo) are now pinned prebuilt binaries in BuildTools/Package.swift (exact version + checksum). Run make bootstrap to install them into BuildTools/bin. Xcode build phases, fastlane, CI and generateMockoloMocks.sh now use these binaries instead of Pods/ or Homebrew.
  • Added SceneDelegate, which now owns the window. App-wide setup (DI, plugins, Firebase, push, deep-link services) stays in AppDelegate. URL handling (Branch, Facebook, Google, MSAL) moved to scene(_:openURLContexts:), because UIKit no longer calls application(_:open:options:) for scene-based apps.
  • Updated README and module-creation docs.

How to test

  1. make bootstrap
  2. Open OpenEdX.xcworkspace and let Xcode resolve packages.
  3. Build and run OpenEdXDev. The app should launch, and social sign-in / deep links should still work.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 6, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Demian-Yushyn!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

IvanStepanok
IvanStepanok previously approved these changes Oct 7, 2026

@IvanStepanok IvanStepanok left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks!

@RawanMatar89 RawanMatar89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @Demian-Yushyn 👏🏻
LGTM for the CocoaPods/SPM migration, the pinned BuildTools package and make bootstrap flow look clean. Approving, with a few notes:

Heads-up for operators using Branch
The UIScene switch breaks fresh start universal links: they used to reach initSession via launchOptions, but under scenes they arrive in connectionOptions.userActivities, which isn't forwarded. Custom-scheme URLs are fine via urlContexts. I think operators using Branch should verify before release. 🙏🏻

Please fix before merge
Revert the signing changes in OpenEdX.xcodeproj (DEVELOPMENT_TEAM = L8PG7LC3Y3), looks like local Xcode churn.

follow-ups
Documentation need to be updated - still says pod install.

@Demian-Yushyn
Demian-Yushyn dismissed IvanStepanok’s stale review October 13, 2026 09:03

The merge-base changed after approval.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Oct 22, 2026
@mphilbrick211 mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: In Eng Review

Development

Successfully merging this pull request may close these issues.

5 participants