Repository navigation
Chore/spm migration - #687
Demian-Yushyn wants to merge 30 commits into
Conversation
Fix/issue 581
|
Thanks for the pull request, @Demian-Yushyn! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
RawanMatar89
left a comment
There was a problem hiding this comment.
great work @Demian-Yushyn 👏🏻
LGTM for the CocoaPods/SPM migration, the pinned BuildTools package and make bootstrap flow look clean. Approving, with a few notes:
Heads-up for operators using Branch
The UIScene switch breaks fresh start universal links: they used to reach initSession via launchOptions, but under scenes they arrive in connectionOptions.userActivities, which isn't forwarded. Custom-scheme URLs are fine via urlContexts. I think operators using Branch should verify before release. 🙏🏻
Please fix before merge
Revert the signing changes in OpenEdX.xcodeproj (DEVELOPMENT_TEAM = L8PG7LC3Y3), looks like local Xcode churn.
follow-ups
Documentation need to be updated - still says pod install.
The merge-base changed after approval.
Summary
Migrates dependency management from CocoaPods to Swift Package Manager and adopts the UIScene life cycle.
Why
pod installstep, no generatedPodsproject, and dependencies resolve directly in Xcode.UIScene life cycle is required for apps built with this SDK.What changed
Podfile/Podfile.lockand the per-module.xcworkspacefiles; all third-party libraries are now SPM packages, pinned in the committedPackage.resolved.BuildTools/Package.swift(exact version + checksum). Runmake bootstrapto install them intoBuildTools/bin. Xcode build phases, fastlane, CI andgenerateMockoloMocks.shnow use these binaries instead ofPods/or Homebrew.SceneDelegate, which now owns the window. App-wide setup (DI, plugins, Firebase, push, deep-link services) stays inAppDelegate. URL handling (Branch, Facebook, Google, MSAL) moved toscene(_:openURLContexts:), because UIKit no longer callsapplication(_:open:options:)for scene-based apps.How to test
make bootstrapOpenEdX.xcworkspaceand let Xcode resolve packages.OpenEdXDev. The app should launch, and social sign-in / deep links should still work.