crow: add PACKAGECONFIG for Boost support - #1060
Open
panekk wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the OpenEmbedded recipe for Crow to track the upstream v1.3.3 release and introduces a configurable build option to use Boost.Asio instead of standalone Asio.
Changes:
- Bump
SRCREVto the commit corresponding to Crow v1.3.3. - Add a
boostPACKAGECONFIGoption intended to switch Crow to Boost.Asio builds. - Make
DEPENDSconditional to select the Asio provider based onPACKAGECONFIG.
Comments suppressed due to low confidence (1)
meta-oe/recipes-support/crow/crow_1.3.3.bb:17
- DEPENDS currently evaluates to an empty string when PACKAGECONFIG includes 'boost', relying on PACKAGECONFIG[boost]'s dependency field to pull in Boost. This makes the effective dependency set harder to reason about (DEPENDS won’t show Boost) and is easy to break if the PACKAGECONFIG entry is edited later. It’s clearer to have DEPENDS directly select the provider (boost vs asio) and keep PACKAGECONFIG focused on CMake args.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Please rebase it on top of latest master and upload PR again. Some part of this has been applied. |
panekk
force-pushed
the
feat/crow-1.3.3
branch
from
August 12, 2026 07:56
bf44e4d to
d8c0a8e
Compare
panekk
changed the title
Author
|
@kraj With the updated master, this is no longer an update of crow, but the other changes are still useful. I updated the commit message and description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add boost PACKAGECONFIG option to build against Boost.Asio. By default, keep using the standalone asio library.