Repository navigation
Require o3forms 4.0.0-SNAPSHOT, the Platform 3.0 build - #40
Merged
Merged
Conversation
o3forms' core-3.x now builds and deploys its own version, 4.0.0-SNAPSHOT (openmrs-module-o3forms#13). 3.0.0-SNAPSHOT is o3forms' main branch, its Platform 2.x build, so core-3.x was compiling against, and requiring, the wrong line. o3FormsVersion sets both the Maven dependency and the omod's require_module, so the omod now requires o3forms 4.0.0-SNAPSHOT at runtime. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TREX stopped before finishing
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



core-3.xpinso3FormsVersionto 3.0.0-SNAPSHOT, which is o3forms'mainbranch, its Platform 2.x build. So this branch compiled against, and required at runtime, the wrong o3forms line. o3forms'core-3.xnow builds and deploys its own version, 4.0.0-SNAPSHOT (openmrs/openmrs-module-o3forms#13). It was published aso3forms-omod-4.0.0-20261013.105649-1.o3FormsVersionsets both the Maven dependency and the omod'srequire_module, so this one line moves both.mvn -U clean verifyon JDK 21 succeeds: api 17 tests and omod 292 tests, with no failures or errors. Maven downloadso3forms-omod-4.0.0-20261013.105649-1.jar.config.xmlhas<require_module version="4.0.0-SNAPSHOT">org.openmrs.module.o3forms</require_module>.core-3.x(43cf8eb) and initializer from Upgrade to support OpenMRS Platform 3.0 mekomsolutions/openmrs-module-initializer#338 (ac75814), came from a local repository, built with-DskipTests. Neither has a published 3.0 SNAPSHOT yet. So this PR's CI will still fail to resolve them, ascore-3.xalready does, until reporting deploys and initializer#338 merges.🤖 Generated with Claude Code