Skip to content

Require o3forms 4.0.0-SNAPSHOT, the Platform 3.0 build - #40

Merged
dkayiwa merged 1 commit into
openmrs:core-3.xfrom
dkayiwa:core-3.x-o3forms-4
Oct 13, 2026
Merged

dkayiwa merged 1 commit into
openmrs:core-3.xfrom
dkayiwa:core-3.x-o3forms-4

Conversation

@dkayiwa

@dkayiwa dkayiwa commented Oct 13, 2026

Copy link
Copy Markdown
Member

core-3.x pins o3FormsVersion to 3.0.0-SNAPSHOT, which is o3forms' main branch, its Platform 2.x build. So this branch compiled against, and required at runtime, the wrong o3forms line. o3forms' core-3.x now builds and deploys its own version, 4.0.0-SNAPSHOT (openmrs/openmrs-module-o3forms#13). It was published as o3forms-omod-4.0.0-20261013.105649-1.

o3FormsVersion sets both the Maven dependency and the omod's require_module, so this one line moves both.

  • mvn -U clean verify on JDK 21 succeeds: api 17 tests and omod 292 tests, with no failures or errors. Maven downloads o3forms-omod-4.0.0-20261013.105649-1.jar.
  • The built omod's config.xml has <require_module version="4.0.0-SNAPSHOT">org.openmrs.module.o3forms</require_module>.
  • The other two dependencies, reporting core-3.x (43cf8eb) and initializer from Upgrade to support OpenMRS Platform 3.0 mekomsolutions/openmrs-module-initializer#338 (ac75814), came from a local repository, built with -DskipTests. Neither has a published 3.0 SNAPSHOT yet. So this PR's CI will still fail to resolve them, as core-3.x already does, until reporting deploys and initializer#338 merges.

🤖 Generated with Claude Code

o3forms' core-3.x now builds and deploys its own version, 4.0.0-SNAPSHOT
(openmrs-module-o3forms#13). 3.0.0-SNAPSHOT is o3forms' main branch, its
Platform 2.x build, so core-3.x was compiling against, and requiring, the
wrong line. o3FormsVersion sets both the Maven dependency and the omod's
require_module, so the omod now requires o3forms 4.0.0-SNAPSHOT at runtime.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

TREX stopped before finishing

  • Plan what to test
  • Set up and test the changed flows
  • Post results

@sonarqubecloud

Copy link
Copy Markdown

@dkayiwa
dkayiwa merged commit 821890d into openmrs:core-3.x Oct 13, 2026
6 of 8 checks passed
@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High impact] The PR appears safe to merge; no actionable defect was found.

Summary

No actionable findings.

  • Patient Documents now uses the Platform 3 build of O3 Forms.

Reviews (1) · Last reviewed commit: "Require o3forms 4.0.0-SNAPSHOT, the Plat..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant