Conversation
mx 5973bfa8..e930099 replaces DocumentManager with the RAII MusicXml class (webern/mx#435) and reshapes ApiError to carry a structured Location and exception cause (webern/mx#436). Neither change is source-compatible, so the pin advances to the stack tip e930099 and the DocumentManager call sites move to the new API: - writeMusicXmlToCallback authors and writes the document through mx::api::fromScore and MusicXml::writeToStream, and the file-local mxResultMessage gives way to mx::api::formatError now that mx formats its own errors. - the test helpers load fixtures with MusicXml::fromFile + getScore and write with fromScore + writeToStream. Denigma builds clean and all 465 tests pass against the new tip. The pin points at the unmerged top of the mx stack (m/mxdev-errinfo), so the change is submitted as a draft until webern/mx#435 and #436 land; the pin should then be re-advanced to the merged main tip.
Collaborator
|
Am holding until you undraft. Thank you for the contribution! |
Author
For context, I thought I’d start “downsteaming” breaking changes and at the same time I’m trying to increase my productivity with agents. One of them misunderstood my intent of “get ready to open a denigma pr (ie once we merge stuff in mx, the obvious time to do it) with “eagerly open a pr that can’t possibly be merged yet” 😅 I’ll close this and open a new PR once I land a few breaking changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOLD: not ready yet. I'm playing with some agent stuff and it overeagerly opened this before I was ready.
What
Adapts Denigma to the top of the mx stack,
e930099(webern/mx#435 "replace DocumentManager with RAII MusicXml", webern/mx#436 "carry structured location and exception cause in api errors"), and advances theMX_GIT_TAG_OR_BRANCHpin to it.Why
mx #435 removes
mx/api/DocumentManager.hand #436 reshapesApiError(pathbecomeslocation.xmlPath, and mx gainsformatError). Neither change is source-compatible, so a fixes-only PR against the current pin cannot build; the pin has to move together with the code.Changes
writeMusicXmlToCallbackauthors and writes the document throughmx::api::fromScoreandMusicXml::writeToStream; errors throwstd::runtime_error(mx::api::formatError(...)), replacing the file-localmxResultMessagehelper.loadScoreDataloads withMusicXml::fromFile+getScore; the non-traditional key signature test writes withfromScore+writeToStream.Verification
e930099viaMX_LOCAL_PATH.m/mxdev-errinfo, PR #436 head), so FetchContent resolves it.Draft until the mx stack lands
This stays a draft until webern/mx#435 and #436 merge. Once they do, the pin should be re-advanced to the merged mx
maintip (this PR's code changes are expected to apply unchanged, sincee930099is the stack tip).