Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #571.
The Cursor browser-auth poller leaves non-2xx response bodies unread. Pending 404 responses and error responses can retain pooled connection resources and delay the next poll.
Value
Keep a waiting browser login from unnecessarily blocking its own subsequent requests in a constrained connection pool.
Approach
Cancel discarded response bodies before the existing status handling. Ignore cleanup rejection so it cannot replace the established pending/error semantics. The same cleanup idiom already exists in the usage provider utilities.
Only four production lines are added. Retry count, backoff, request/login deadlines and credentials remain unchanged. The existing request timeout bounds retention; this is not a claim of permanent leakage or universal login failure.
Validation
Pool.destroy, so a fullbun testrun of this file is not claimed.bun run check,git diff --check, one scoped read-only review — pass/no actionable findings.Impact