Conversation
Contributor
Author
|
CI readback for This same test/line/locator failure is present on the current base I have kept that separate baseline issue out of scope. A maintainer rerun of the failed Web lane would be helpful; I do not have upstream rerun permissions and have not pushed a no-op commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #577.
At the legal 8,000-byte answer limit,
ask_userrejects Enter and Backspace as if their raw control bytes were new inserted text. A valid full draft cannot reach review or be shortened.Value
Keep valid maximum-size answers editable and submittable without weakening the input budget or confirmation flow.
Approach
Use the outer range check only to bound input allocation. Let the existing
prospectiveAnswerDraftFitspath distinguish inserted text from editor commands. Keep the post-editor byte check and all existing limits.This does not implement #499's overlay reopen, draft lifecycle or unanswered-review work; that claimed scope stays separate.
Validation
ask_user+ actual native Pi Editor: exact-size paste followed by Enter; full draft followed by Backspace and replacement text.bun run check,git diff --check, one scoped read-only review — pass/no actionable findings.Impact