Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #575.
Native Pi
bashExecutionmessages carryexitCodeandcancelled, not theisErrorfield alone used by the Sessions preview. Failed commands can therefore appear without a failure marker in history.Value
Preserve the command's actual failure or cancellation outcome when reviewing a past session.
Approach
Project native cancellation and defined nonzero exit codes onto the existing Bash preview error flag. Preserve explicit legacy
isError; keep unknown exit status unmarked. No execution or canonical-history changes.Validation
AgentSession.executeBash("exit 7")produces the canonical message used by the preview regression; no model/provider call or private state.bun run check,git diff --check, one scoped read-only review — pass/no actionable findings.Impact