Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #581.
Git call labels can render terminal control bytes before argument validation runs.
git_show,git_diff, andgit_loginterpolate raw revision/path/file text into Pi's call-label component; rejecting the later execution does not sanitize that earlier display.Value
Keep call-label output safe and single-line while preserving the exact arguments used for validation and execution.
Approach
Sanitize each final call label with the existing
sanitizeTerminalText, then normalize whitespace. All three sibling Git tools use the same small helper. The existing file-search argument-display pattern provides the precedent.This branch is independent of #570's result failure status, #564's Git argument separator, and #368's process helper refactor. No execute, argv, result, or schema changes are included.
Validation
ToolExecutionComponent: harmless title-control markers appear in output before the fix and are absent after it. Actual execute calls still reject the original arguments.bun run check,git diff --check, one scoped read-only review — pass/no actionable findings.Impact