fix(user-input-fold): preserve supplementary characters at prose cutoff - #586
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #585.
The first-line prose cutoff in folded user messages can split an emoji or supplementary CJK character, producing a replacement character when terminal output is encoded as UTF-8.
Value
Keep the preview faithful to complete input characters while retaining the existing preview size and folding behavior.
Approach
Move the existing cutoff back one code unit only when it falls between a matching high/low surrogate pair. No new helper, configuration or rendering framework; all other folding paths remain unchanged.
Validation
node --experimental-strip-types --test tests/extensions/user-input-fold/index.test.ts,bun run check,git diff --check— pass.autoreview --mode local --engine codex --model gpt-6-astra --thinking xhigh --no-web-search): helper exit0, no actionable findings.Impact