Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #588.
The worktree handoff's UTF-8 check mistakes a literal U+FFFD for evidence of a decode failure. Valid patches and untracked/ignored filenames can therefore prevent handoff capture.
Value
Preserve valid text exactly while retaining the existing fail-closed protection against lossy recovery artifacts.
Approach
Read bounded Git stdout as bytes and decode it with
TextDecoderin fatal mode, preserving any BOM. Remove the duplicate character heuristic innulPaths, whose inputs already pass that decoder. Git arguments, deadlines, size caps, manifest schema and cleanup policy are unchanged.Validation
prepareWorktreeHandoffand read the persisted artifact: literal U+FFFD in a tracked patch and in untracked/ignored names each fail before and pass after.0xffbyte in a Git text patch is still refused; no artifact is published and the checkout remains. Existing binary-patch and cleanup tests remain passing.node --experimental-strip-types --test tests/extensions/workflows/worktree-handoff.test.ts tests/extensions/shared/worktree.test.ts,bun run check,git diff --check— pass.autoreview --mode local --engine codex --model gpt-6-astra --thinking xhigh --no-web-search): helper exit0, no actionable findings.Impact