Skip to content

NO-ISSUE: OWNERS: Pratik is no longer at Red Hat :( - #271

Open
wking wants to merge 1 commit into
openshift:masterfrom
wking:emeritus-pratik
Open

NO-ISSUE: OWNERS: Pratik is no longer at Red Hat :(#271
wking wants to merge 1 commit into
openshift:masterfrom
wking:emeritus-pratik

Conversation

@wking

@wking wking commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated repository review and approval assignments to reflect a change in contributor status.
    • No user-facing product functionality or behavior was changed.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@wking: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 22eb1a96-b7c1-474d-a054-293dbfa1c9e3

📥 Commits

Reviewing files that changed from the base of the PR and between bd47825 and 59c09a1.

📒 Files selected for processing (1)
  • OWNERS

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The OWNERS file removes PratikMahajan from approvers and reviewers, then adds the name to emeritus_approvers.

Changes

Ownership status update

Layer / File(s) Summary
Update approver status
OWNERS
The file moves PratikMahajan from the active approvers and reviewers lists to emeritus_approvers.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 59c09

This is a localized maintainer-list update in OWNERS, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: it updates OWNERS because Pratik is no longer at Red Hat. The NO-ISSUE prefix and emoticon do not prevent understanding.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request changes only the root OWNERS file. It removes PratikMahajan from approvers and reviewers and adds the name to emeritus_approvers. It changes no test files or Ginkgo test titles,…
Test Structure And Quality ✅ Passed PASS: The pull request changes only the root OWNERS file. The diff removes PratikMahajan from approvers and reviewers and adds the name to emeritus_approvers. It adds or changes no Ginkgo te…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only the root OWNERS file. The diff removes PratikMahajan from approvers and reviewers and adds the name to emeritus_approvers. It adds no Ginkgo e2e tests, Op…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only the root OWNERS file. It adds PratikMahajan to emeritus_approvers and removes the name from approvers and reviewers. The diff contains no Go files or new …
Topology-Aware Scheduling Compatibility ✅ Passed PASS — The pull request changes only the root OWNERS metadata file. The diff contains no deployment manifests, operator code, controllers, or scheduling-related changes. The topology-aware schedulin…
Ote Binary Stdout Contract ✅ Passed PASS. The pull request changes only OWNERS: it removes PratikMahajan from approvers and reviewers and adds the entry to emeritus_approvers. git diff-tree shows no source or test changes. T…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only the root OWNERS file. The exact diff removes PratikMahajan from approvers and reviewers and adds the name to emeritus_approvers. It adds no Ginkgo tests, …
No-Weak-Crypto ✅ Passed PASS: The pull request changes only OWNERS. It moves PratikMahajan from approvers and reviewers to emeritus_approvers. The patch introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custo…
Container-Privileges ✅ Passed PASS. The pull request changes only OWNERS. It moves PratikMahajan from approvers and reviewers to emeritus_approvers. No container or Kubernetes manifest changes, and no privilege-related c…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request changes only the OWNERS metadata file. It moves PratikMahajan between ownership lists and adds no logging code or log message. The changed lines do not contain passwords, to…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only the root OWNERS file. It removes PratikMahajan from approvers and reviewers and adds the name to emeritus_approvers. It changes no test files or Ginkgo test titles, so it introduces no unstable or overly-specific test name.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only the root OWNERS file. The diff removes PratikMahajan from approvers and reviewers and adds the name to emeritus_approvers. It adds or changes no Ginkgo test code, so the five test-quality requirements do not apply.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only the root OWNERS file. The diff removes PratikMahajan from approvers and reviewers and adds the name to emeritus_approvers. It adds no Ginkgo e2e tests, OpenShift API references, namespaces, or MicroShift compatibility assumptions.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only the root OWNERS file. It adds PratikMahajan to emeritus_approvers and removes the name from approvers and reviewers. The diff contains no Go files or new Ginkgo test declarations, so the SNO compatibility check does not apply.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS — The pull request changes only the root OWNERS metadata file. The diff contains no deployment manifests, operator code, controllers, or scheduling-related changes. The topology-aware scheduling check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS. The pull request changes only OWNERS: it removes PratikMahajan from approvers and reviewers and adds the entry to emeritus_approvers. git diff-tree shows no source or test changes. Therefore, the pull request introduces no process-level stdout write.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only the root OWNERS file. The exact diff removes PratikMahajan from approvers and reviewers and adds the name to emeritus_approvers. It adds no Ginkgo tests, IP handling, URLs, registry references, or external connectivity requirements.

Full details: No-Weak-Crypto

Explanation

PASS: The pull request changes only OWNERS. It moves PratikMahajan from approvers and reviewers to emeritus_approvers. The patch introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret-comparison code.

Full details: Container-Privileges

Explanation

PASS. The pull request changes only OWNERS. It moves PratikMahajan from approvers and reviewers to emeritus_approvers. No container or Kubernetes manifest changes, and no privilege-related changed lines, are present.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request changes only the OWNERS metadata file. It moves PratikMahajan between ownership lists and adds no logging code or log message. The changed lines do not contain passwords, tokens, API keys, or other sensitive data exposed through logs.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Aug 21, 2026
Comment thread OWNERS Outdated
@openshift-ci openshift-ci Bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 27, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test operator-e2e-hypershift-local-graph-data
/test operator-e2e-new-ocp-published-graph-data-fips

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DavidHurta

Copy link
Copy Markdown
Contributor

/verified by @DavidHurta

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 27, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@DavidHurta: This PR has been marked as verified by @DavidHurta.

Details

In response to this:

/verified by @DavidHurta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0c73b3c and 2 for PR HEAD 59c09a1 in total

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@wking: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/install-bundle 59c09a1 link true /test install-bundle

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants