OCPBUGS-114669: [release-4.22] GCP Alternate Universe Domain Support for WIF

[patrickdillon]

Manual cherry-pick of #1073

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2c754403-ae00-437d-a214-eaa4f5419886

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-114669, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-112145 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-112145 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
• bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick of #1073

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[patrickdillon]

/hold

Depends on openshift/api#3022

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon
Once this PR has been reviewed and has the lgtm label, please assign dlom for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

❌ Patch coverage is 32.50000% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.74%. Comparing base (26005d2) to head (904d0cc).

Files with missing lines	Patch %	Lines
pkg/gcp/actuator/actuator.go	0.00%	20 Missing ⚠️
pkg/cmd/provisioning/gcp/create_all.go	0.00%	3 Missing ⚠️
...kg/cmd/provisioning/gcp/create_service_accounts.go	75.00%	2 Missing and 1 partial ⚠️
...visioning/gcp/create_workload_identity_provider.go	80.00%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.22    #1092      +/-   ##
================================================
- Coverage         46.80%   46.74%   -0.06%     
================================================
  Files                98       98              
  Lines             12594    12619      +25     
================================================
+ Hits               5894     5899       +5     
- Misses             6045     6064      +19     
- Partials            655      656       +1     

Files with missing lines	Coverage Δ
...visioning/gcp/create_workload_identity_provider.go	58.67% <80.00%> (+0.34%)	⬆️
pkg/cmd/provisioning/gcp/create_all.go	0.00% <0.00%> (ø)
...kg/cmd/provisioning/gcp/create_service_accounts.go	52.65% <75.00%> (+0.14%)	⬆️
pkg/gcp/actuator/actuator.go	49.02% <0.00%> (-1.53%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

@patrickdillon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	904d0cc	link	true	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.