Skip to content

NO-ISSUE: Fix issue lookup author for rebase target branch - #7240

Open
pacevedom wants to merge 1 commit into
openshift:mainfrom
pacevedom:fix-issue-lookup-rebase
Open

NO-ISSUE: Fix issue lookup author for rebase target branch#7240
pacevedom wants to merge 1 commit into
openshift:mainfrom
pacevedom:fix-issue-lookup-rebase

Conversation

@pacevedom

@pacevedom pacevedom commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Updated freeze-issue handling to correctly recognize the automated issue author.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 25, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@pacevedom: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d0e8b574-b887-4378-9ba9-ba8c88cc96ab

📥 Commits

Reviewing files that changed from the base of the PR and between 8e16b12 and 03288d1.

📒 Files selected for processing (1)
  • scripts/pyutils/ghutils.py

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

The freeze issue author identifier changes from openshift-ci to openshift-ci[bot]. Freeze branch lookup now matches the bot login.

Changes

Freeze issue author matching

Layer / File(s) Summary
Update freeze issue author identifier
scripts/pyutils/ghutils.py
GithubUtils._FREEZE_ISSUE_AUTHOR now uses openshift-ci[bot] when _get_frozen_branches identifies open freeze issues.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 03288

This is a localized issue-lookup behavior fix with no actionable merge-blocking risk remaining; it is merge-ready after normal checks and review.

Suggested labels: ready-for-human-review

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the change to the issue lookup author identifier used for the rebase target branch.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR changes only _FREEZE_ISSUE_AUTHOR in scripts/pyutils/ghutils.py from openshift-ci to the static identifier openshift-ci[bot]. The diff adds no Ginkgo tests or test titles, and the…
Test Structure And Quality ✅ Passed PASS: The pull request changes only scripts/pyutils/ghutils.py, replacing _FREEZE_ISSUE_AUTHOR with openshift-ci[bot]. The parent-to-HEAD diff contains no Ginkgo test files or test code, so the …
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only the Python constant _FREEZE_ISSUE_AUTHOR from openshift-ci to openshift-ci[bot]. It adds no Ginkgo e2e tests, Go test files, or test-directory changes. The Mi…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only one line in scripts/pyutils/ghutils.py, a Python author identifier from openshift-ci to openshift-ci[bot]. It adds no Ginkgo e2e tests or multi-node assumptio…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only scripts/pyutils/ghutils.py. The exact diff changes _FREEZE_ISSUE_AUTHOR from openshift-ci to openshift-ci[bot]. It does not add or modify deployment manifes…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only the Python constant _FREEZE_ISSUE_AUTHOR in scripts/pyutils/ghutils.py. The diff adds no stdout write and touches no OTE binary or Go suite setup code. The modu…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The pull request changes only the Python constant _FREEZE_ISSUE_AUTHOR from openshift-ci to openshift-ci[bot] in scripts/pyutils/ghutils.py. It adds no Ginkgo e2e tests, IPv4 assumptions…
No-Weak-Crypto ✅ Passed PASS. The pull request changes only _FREEZE_ISSUE_AUTHOR from "openshift-ci" to "openshift-ci[bot]" in scripts/pyutils/ghutils.py. The patch contains no MD5, SHA1, DES, RC4, 3DES, Blowfish, EC…
Container-Privileges ✅ Passed PASS. The pull request changes one Python constant in scripts/pyutils/ghutils.py: openshift-ci becomes openshift-ci[bot]. The commit changes no container or Kubernetes manifest. The patch contai…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request changes only _FREEZE_ISSUE_AUTHOR from openshift-ci to the public GitHub bot login openshift-ci[bot]. The diff adds no logging call and does not introduce passwords, token…
Full details: Stable And Deterministic Test Names

Explanation

PASS: The PR changes only _FREEZE_ISSUE_AUTHOR in scripts/pyutils/ghutils.py from openshift-ci to the static identifier openshift-ci[bot]. The diff adds no Ginkgo tests or test titles, and the changed Python file contains no It, Describe, Context, or When declarations. Therefore, the check has no applicable failure condition.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only scripts/pyutils/ghutils.py, replacing _FREEZE_ISSUE_AUTHOR with openshift-ci[bot]. The parent-to-HEAD diff contains no Ginkgo test files or test code, so the listed test-structure requirements do not apply.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only the Python constant _FREEZE_ISSUE_AUTHOR from openshift-ci to openshift-ci[bot]. It adds no Ginkgo e2e tests, Go test files, or test-directory changes. The MicroShift compatibility check is therefore not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only one line in scripts/pyutils/ghutils.py, a Python author identifier from openshift-ci to openshift-ci[bot]. It adds no Ginkgo e2e tests or multi-node assumptions.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only scripts/pyutils/ghutils.py. The exact diff changes _FREEZE_ISSUE_AUTHOR from openshift-ci to openshift-ci[bot]. It does not add or modify deployment manifests, operators, controllers, replicas, affinity, topology spread, node selectors, tolerations, or PDBs. The topology-aware scheduling check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only the Python constant _FREEZE_ISSUE_AUTHOR in scripts/pyutils/ghutils.py. The diff adds no stdout write and touches no OTE binary or Go suite setup code. The module contains no print, stdout, or sys.stdout use.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS. The pull request changes only the Python constant _FREEZE_ISSUE_AUTHOR from openshift-ci to openshift-ci[bot] in scripts/pyutils/ghutils.py. It adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request changes only _FREEZE_ISSUE_AUTHOR from "openshift-ci" to "openshift-ci[bot]" in scripts/pyutils/ghutils.py. The patch contains no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cryptography, or secret-comparison changes.

Full details: Container-Privileges

Explanation

PASS. The pull request changes one Python constant in scripts/pyutils/ghutils.py: openshift-ci becomes openshift-ci[bot]. The commit changes no container or Kubernetes manifest. The patch contains none of privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation. Therefore, the custom check has no applicable failure condition.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request changes only _FREEZE_ISSUE_AUTHOR from openshift-ci to the public GitHub bot login openshift-ci[bot]. The diff adds no logging call and does not introduce passwords, tokens, API keys, PII, session IDs, hostnames, or customer data into logs. The existing debug message uses this identifier only for issue filtering.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from agullon and ggiguash August 25, 2026 08:14
@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2026
@coderabbitai coderabbitai Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 25, 2026
@eslutsky

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@pacevedom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-bootc-el10 03288d1 link true /test e2e-aws-tests-bootc-el10
ci/prow/e2e-aws-tests-bootc-el9 03288d1 link true /test e2e-aws-tests-bootc-el9
ci/prow/e2e-aws-tests-arm 03288d1 link true /test e2e-aws-tests-arm
ci/prow/e2e-aws-tests-bootc-arm-el10 03288d1 link true /test e2e-aws-tests-bootc-arm-el10
ci/prow/e2e-aws-tests 03288d1 link true /test e2e-aws-tests
ci/prow/e2e-aws-tests-bootc-arm-el9 03288d1 link true /test e2e-aws-tests-bootc-arm-el9

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@copejon

copejon commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants