Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@ recommended/Alert=Unknown:

Upstream update service: https://api.integration.openshift.com/api/upgrades_info/graph
Channel: candidate-4.14 (available channels: candidate-4.14, candidate-4.15, eus-4.14, fast-4.14, stable-4.14)

error: no updates to 4.12 available, so cannot display context for the requested release 4.12.51
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@ recommended/UpdatePrecheckAlerts/VirtHandlerDaemonSetRolloutFailing/2=False:
Reason: Alert:firing
Message: warning alert VirtHandlerDaemonSetRolloutFailing firing, suggesting issues worth investigating before updating the cluster. Test summary. The alert description is: Test description. <alert does not have a runbook_url annotation>


error: no updates available, so cannot display context for the requested release 1.2.3-not-important
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,4 @@ recommended/CriticalAlerts/VirtHandlerDaemonSetRolloutFailing/0=False:
Reason: Alert:firing
Message: critical alert VirtHandlerDaemonSetRolloutFailing firing, suggesting significant cluster issues worth investigating. Test summary. The alert description is: Test description. <alert does not have a runbook_url annotation>


error: no updates available, so cannot display context for the requested release 1.2.3-not-important
2 changes: 1 addition & 1 deletion pkg/cli/admin/upgrade/recommend/examples_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func TestExamples(t *testing.T) {
opts.ErrOut = &stderr

if err := opts.Run(context.Background()); err != nil {
compareWithFixture(t, bytes.Join([][]byte{stdout.Bytes(), []byte("\nerror: "), []byte(err.Error()), []byte("\n")}, []byte{}), cv, variant.outputSuffix)
compareWithFixture(t, bytes.Join([][]byte{stdout.Bytes(), []byte("error: "), []byte(err.Error()), []byte("\n")}, []byte{}), cv, variant.outputSuffix)
} else {
compareWithFixture(t, stdout.Bytes(), cv, variant.outputSuffix)
}
Expand Down
3 changes: 3 additions & 0 deletions pkg/cli/admin/upgrade/recommend/recommend.go
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,9 @@ func (o *options) Run(ctx context.Context) error {
}
unaccepted := issues.Difference(accept)
if unaccepted.Len() > 0 {
if !o.quiet {
fmt.Fprintln(o.Out)
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
if cvoChecking {
return fmt.Errorf("There are issues that apply to this cluster and have not been accepted. `oc adm upgrade accept` can be used to accept them: %s\n", strings.Join(sets.List(unaccepted), ","))
}
Expand Down