[DNM] [cluster-bot] Fix virtual media boot on Quanta QuantaEdge EGN77C-2U - #163
Open
jacob-anders wants to merge 1 commit into
Open
[DNM] [cluster-bot] Fix virtual media boot on Quanta QuantaEdge EGN77C-2U#163jacob-anders wants to merge 1 commit into
jacob-anders wants to merge 1 commit into
Conversation
These BMCs present virtual media to the host as a USB removable device (the slots are named USB1/USB2 and report "Virtual Removable Media"), and the host fails to boot when Cd is requested as the boot source override target, even though the media is correctly inserted. UsbCd is not offered by these machines, so Usb is now sent instead. Redfish provides no way to discover this. MediaTypes describes the BMC-side emulated device while BootSourceOverrideTarget describes the host-side enumeration, and nothing in the data model links the two, so this remains a vendor quirk. The existing SuperMicro Cd to UsbCd substitution and this one are now driven by a BOOT_SOURCE_TARGET_QUIRKS table matched on manufacturer and optionally model. The model match matters here: QuantaGrid models share a manufacturer string with the EGN77C-2U, expose a conventional virtual optical device, and must not be rewritten. Substitutions continue to be applied only when the replacement target is advertised in BootSourceOverrideTarget@Redfish.AllowableValues. The SuperMicro manufacturer check is relaxed from an exact match to a case-insensitive substring match, and substitutions are now logged at INFO rather than DEBUG. Signed-off-by: Jacob Anders <jacob-anders-dev@proton.me> Assisted-By: Claude Opus 5 (1M context) (cherry picked from commit eed027e)
Author
|
/hold |
openshift-ci
Bot
added
do-not-merge/hold
Author
|
/approve cancel |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
removed
the
approved
|
@jacob-anders: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These BMCs present virtual media to the host as a USB removable device (the slots are named USB1/USB2 and report "Virtual Removable Media"), and the host fails to boot when Cd is requested as the boot source override target, even though the media is correctly inserted. UsbCd is not offered by these machines, so Usb is now sent instead.
Redfish provides no way to discover this. MediaTypes describes the BMC-side emulated device while BootSourceOverrideTarget describes the host-side enumeration, and nothing in the data model links the two, so this remains a vendor quirk.
The existing SuperMicro Cd to UsbCd substitution and this one are now driven by a BOOT_SOURCE_TARGET_QUIRKS table matched on manufacturer and optionally model. The model match matters here: QuantaGrid models share a manufacturer string with the EGN77C-2U, expose a conventional virtual optical device, and must not be rewritten. Substitutions continue to be applied only when the replacement target is advertised in BootSourceOverrideTarget@Redfish.AllowableValues.
The SuperMicro manufacturer check is relaxed from an exact match to a case-insensitive substring match, and substitutions are now logged at INFO rather than DEBUG.
Assisted-By: Claude Opus 5 (1M context)
(cherry picked from commit eed027e)