Skip to content

Fix stale v0.38.0 version references in harness config comments #969

Description

@fullsend-ai-retro

What happened

PR #968 bumped all fullsend version pins from v0.38.0 to v0.43.0. The base: URLs in .fullsend/harness/code.yaml and .fullsend/harness/triage.yaml were correctly updated to SHA 7ab05564b3c9c0ab20197e0c8572b5905ffd75ca (the v0.43.0 agents commit), but the inline comments in both files still say "pinned to agents v0.38.0" and reference "v0.38.0 fetches the work item host-side". Neither CodeRabbit's automated review nor the human reviewer (RaphaelBut) flagged the stale comments.

What could go better

The version comments should have been updated alongside the SHA pins. This is a common oversight in manual version bump PRs — the code changes (SHA, digest) are the focus, and prose comments describing the pinned version get left behind. Confidence is high that this is a genuine stale-comment bug: the comments explicitly reference "v0.38.0" while the SHAs now correspond to v0.43.0. The behavioral descriptions (e.g., "v0.38.0 fetches the work item host-side") may still be accurate for v0.43.0, but the version label is misleading regardless.

Proposed change

Update the header comments in both .fullsend/harness/code.yaml and .fullsend/harness/triage.yaml to replace all references to "v0.38.0" with "v0.43.0". Specifically:

  • In code.yaml: change "pinned to agents v0.38.0" to "pinned to agents v0.43.0" and "v0.38.0 fetches the work item host-side" to "v0.43.0 fetches the work item host-side" (lines 3 and 6 of the header comment).
  • In triage.yaml: change "pinned to agents v0.38.0" to "pinned to agents v0.43.0" and "v0.38.0 fetches the work item host-side" to "v0.43.0 fetches the work item host-side" (lines 3 and 6 of the header comment).

Note: fullsend-ai/fullsend#6589 proposes a CI check that would catch this class of stale-comment issue generically for future pin bumps.

Validation criteria

After the fix, grep -r 'v0\.38\.0' .fullsend/harness/ should return no results. The version references in both harness config comments should match the actual pinned version (v0.43.0).


Generated by retro agent from #968

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions