OCPBUGS-93655: remote/azuread: use Secret type for OAuth client_secret [release-4.15] - #362
Conversation
…th client_secret Fixes CVE-2026-42151 (GHSA-wg65-39gg-5wfj). OAuthConfig.ClientSecret was typed as a plain string, so it bypassed Prometheus's secret redaction and was exposed in plaintext via the /api/v1/status/config API endpoint. Change it to config_util.Secret so it marshals to <secret> like other credentials.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@tonyxrmdavidson: This pull request references Jira Issue OCPBUGS-93655, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tonyxrmdavidson The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@tonyxrmdavidson: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/restest-required |
|
we lack a valid dependent OCPBUGS ticket on |
Fixes CVE-2026-42151 (GHSA-wg65-39gg-5wfj). OAuthConfig.ClientSecret was typed as a plain string, so it bypassed Prometheus's secret redaction and was exposed in plaintext via the
/api/v1/status/config API endpoint. Change it to config_util.Secret so it marshals to like other credentials.