Skip to content

OCPBUGS-93655: remote/azuread: use Secret type for OAuth client_secret [release-4.15] - #362

Open
tonyxrmdavidson wants to merge 1 commit into
openshift:release-4.15from
tonyxrmdavidson:OCPBUGS-93655-CVE-2026-42151-4-15
Open

OCPBUGS-93655: remote/azuread: use Secret type for OAuth client_secret [release-4.15] #362
tonyxrmdavidson wants to merge 1 commit into
openshift:release-4.15from
tonyxrmdavidson:OCPBUGS-93655-CVE-2026-42151-4-15

Conversation

@tonyxrmdavidson

Copy link
Copy Markdown

Fixes CVE-2026-42151 (GHSA-wg65-39gg-5wfj). OAuthConfig.ClientSecret was typed as a plain string, so it bypassed Prometheus's secret redaction and was exposed in plaintext via the
/api/v1/status/config API endpoint. Change it to config_util.Secret so it marshals to like other credentials.

…th client_secret

Fixes CVE-2026-42151 (GHSA-wg65-39gg-5wfj). OAuthConfig.ClientSecret
was typed as a plain string, so it bypassed Prometheus's secret
redaction and was exposed in plaintext via the
/api/v1/status/config API endpoint. Change it to config_util.Secret
so it marshals to <secret> like other credentials.
@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 1, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@tonyxrmdavidson: This pull request references Jira Issue OCPBUGS-93655, which is invalid:

  • expected Jira Issue OCPBUGS-93655 to depend on a bug targeting a version in 4.16.0, 4.16.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fixes CVE-2026-42151 (GHSA-wg65-39gg-5wfj). OAuthConfig.ClientSecret was typed as a plain string, so it bypassed Prometheus's secret redaction and was exposed in plaintext via the
/api/v1/status/config API endpoint. Change it to config_util.Secret so it marshals to like other credentials.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tonyxrmdavidson
Once this PR has been reviewed and has the lgtm label, please assign marioferh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown

@tonyxrmdavidson: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@simonpasquier

Copy link
Copy Markdown

/restest-required

@simonpasquier

Copy link
Copy Markdown

we lack a valid dependent OCPBUGS ticket on release-4.16.

@tonyxrmdavidson tonyxrmdavidson changed the title [release-4.15] OCPBUGS-93655: remote/azuread: use Secret type for OAuth client_secret OCPBUGS-93655: remote/azuread: use Secret type for OAuth client_secret [release-4.15] Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants