Skip to content

Non-copy values in slotmap on stable 1.49 馃帀#46

Description

@Uriopass

With 1.49, ManuallyDrop in unions is coming on stable.

I see the code is already written using ManuallyDrop, which means that slotmap is already ready to be built on 1.49 and onwards! (I tested on beta)
However, it is currently under the unstable feature flag, which also enables the TryReserve API that, sadly, is not stable yet.

What should be the course of action to enable users to use non-copy types on stable?

I propose to remove the Slottable trait entirely and release a 0.5.0 version of the crate since this would break backward compatibility.

Another proposition would be to keep the unstable feature flag with the same semantics, and introduce a new flag to specifically enable non-copy types.

I'd be happy to do the PR whichever way you prefer.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions