Repository navigation
std_and_conj_hlmoff: key SphHarmTimeSeries modes by (l,m) - #433
Merged
oshaughnessy-junior merged 3 commits intoOct 8, 2026
Merged
Conversation
The SphHarmTimeSeries branch stored each mode under the undefined name 'mode', raising UnboundLocalError. Add a regression test that drives that branch for both the deltaF-set and deltaF=None paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
October 7, 2026 23:54 — with 
GitHub Actions
Active
GitHub Actions
Active
![interhost-cross-review-canary-v2[bot]](https://avatars.githubusercontent.com/u/274802661?s=60&v=4){kind=small}
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
October 8, 2026 00:49 — with
GitHub Actions
Active
GitHub Actions
Active
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
October 8, 2026 09:24 — with
GitHub Actions
Active
GitHub Actions
Active
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
October 8, 2026 10:04 — with
GitHub Actions
Active
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std_and_conj_hlmoffhas a branch for whenhlmoftreturns aSphHarmTimeSeriesinstead of a dict. That branch stored each mode ashlmsT[mode]=hxx, butmodeis not defined in that scope, so the call raisedUnboundLocalError. The fix stores under(l,m). No defaults change.The new test,
test/test_std_and_conj_hlmoff_sphharm.py, monkeypatcheshlmoftto return a TaylorT4SimInspiralChooseTDModeslist. It checks the mode keys and each mode's FFT and conjugate FFT, withdeltaFboth set andNone.Mutation check (ldas-grid, IGWN CVMFS python, no GPU,
OMP_NUM_THREADS=1): the fixed code passes 2/2. Each of three mutants fails 2/2: the originalmode, the constant key(2,2), and(l,-m). On the same host,test_lisa_lalsimutils_compat.pyandtest_calmarg_ile_waveform_alignment.pyalso pass (16 tests, including the new ones).Found 2026-10-07 by the early-time compression team's code inventory.
🤖 Generated with Claude Code