Repository navigation
plan #76: publish releases to PyPI - #78
Merged
Merged
Conversation
Triage of the AI-drafted ticket plus the resolved decisions: two personal PyPI owners, a single required reviewer on the `pypi` environment, a permanent opt-in TestPyPI rehearsal, and no backfill of rel-1.16.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCxWh2HqjqhsmLwSJbJAWE
…hors (PR #78 review) - D2: release-dist retention 7 -> 30 days, so an approval or re-run can still find the artifact; a full re-run is no substitute. - D3a: skip-existing on both uploads, so a partial upload is recoverable; D5's digest check is what keeps a real conflict loud. - D5: spell out the pip-download verification (--no-deps, --ignore-missing). - D7: fragment-only README links become absolute too. - Docs: quote the editable-install extras in README.md and the cookbook README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCxWh2HqjqhsmLwSJbJAWE
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
Review effort: Lite
Findings: 1
Open (4)
pip installcommand is split across a newline inside inline code, which will render poorly… · New{local_scheme=\"no-local-version\"}here, but later… · New#78… · New#78… · New
What changed in this PR
Adds a detailed implementation plan for enabling PyPI publishing for dp-python-lib releases (Issue #76), including workflow changes, TestPyPI rehearsal, documentation updates, and release process safeguards.
Changes:
- Adds a new ticket plan documenting design decisions and sequencing for PyPI + TestPyPI publishing.
- Specifies required manual GitHub/PyPI environment setup and workflow gating/verification steps.
- Outlines doc and release-checklist updates needed to support PyPI as an installation channel.
| File | Description |
|---|---|
| plan/tickets/76/plan.md | Introduces the end-to-end plan/design for enabling and verifying PyPI publishing for releases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…s (Copilot review) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCxWh2HqjqhsmLwSJbJAWE
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #76
Plan-only PR: adds
plan/tickets/76/plan.md, the triage and implementation plan for enabling the disabledpublish-pypijob. The workflow and docs change comes in a later PR (Closes #76).What triage found beyond the draft
1.16.1.dev61+g496f0e0), which PyPI and TestPyPI reject. A setuptools-scm override, applied to dispatch builds only, fixes this; verified locally.publish-pypiruns alongside the GitHub Release. The plan makes it run after (needs: [build, publish-github-release]), since a PyPI upload can't be replaced.SHA256SUMS.pip install dp-python-lib[analysis]works. It doesn't today, and unquoted it also fails in zsh.pypienvironment must exist before the workflow change merges. A job naming a missing environment creates it with no protection rules.Decisions (2026-10-05)
Two personal PyPI owners (D1), one required reviewer (D2), a permanent opt-in TestPyPI dispatch input (D3), and the next release first with no backfill (D6). Open item: name the second PyPI owner before the first release.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UCxWh2HqjqhsmLwSJbJAWE