docs: add contribution note for #65660, #65661, #65662, #65664 - #15
Open
leah-1ee wants to merge 4 commits into
Open
docs: add contribution note for #65660, #65661, #65662, #65664#15leah-1ee wants to merge 4 commits into
leah-1ee wants to merge 4 commits into
Conversation
PR #65660 에 대한 기여노트 작성
PR #65661에 대한 기여노트 작성
PR #65662에 대한 기여노트 작성
PR #65664에 대한 기여노트 작성
There was a problem hiding this comment.
Pull request overview
This PR adds four new contribution notes documenting the work and learnings from upstream Node.js PRs #65660, #65661, #65662, and #65664.
Changes:
- Add a contribution note for
internalBinding('profiler')typings work (#65660) - Add a contribution note for
internalBinding('fs_event_wrap')typings work (#65661) - Add a contribution note for
internalBinding('task_queue')typings work (#65662) - Add a contribution note for
internalBinding('stream_pipe')typings work (#65664)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| contributions/65660.md | New contribution note for profiler internalBinding typings PR |
| contributions/65661.md | New contribution note for fs_event_wrap internalBinding typings PR |
| contributions/65662.md | New contribution note for task_queue internalBinding typings PR |
| contributions/65664.md | New contribution note for stream_pipe internalBinding typings PR |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+5
| --- | ||
| pr-url: https://github.com/nodejs/node/pull/65660 | ||
| --- | ||
| ## 문제 내용 | ||
| Node.js의 `internalBinding('profiler')`에 대한 타입 선언이 `typings/internalBinding/`에 없었습니다. |
Comment on lines
+1
to
+5
| --- | ||
| pr-url: https://github.com/nodejs/node/pull/65661 | ||
| --- | ||
| ## 문제 내용 | ||
| `internalBinding('fs_event_wrap')`의 `FSEvent` 클래스에 대한 타입 선언이 없었습니다. |
Comment on lines
+1
to
+5
| --- | ||
| pr-url: https://github.com/nodejs/node/pull/65662 | ||
| --- | ||
| ## 문제 내용 | ||
| `internalBinding('task_queue')`에 대한 타입 선언이 없었습니다. |
Comment on lines
+1
to
+5
| --- | ||
| pr-url: https://github.com/nodejs/node/pull/65664 | ||
| --- | ||
| ## 문제 내용 | ||
| `internalBinding('stream_pipe')`의 `StreamPipe` 클래스에 대한 타입 선언이 없었습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #65660, #65661, #65662, #65664 에 대한 기여노트를 작성했습니다.