Skip to content

Pinned advisory review: fall back to a body-only review on the same commit, not an issue comment #569

Closed

Description

@renmengye

Need

When a review pinned to the labeled head (#462, #566) is refused, posting.post_round_review re-reads the head and, if it has not moved, posts the findings as an issue comment. Issue comments carry no commit pin, so a push between that read and the post puts findings for the old head on the new one. The window is one API round trip; the comment's round stamp still names the reviewed head.

Build

Under a pin, the fallback is a review with commit_id set to the same head and the findings in its body (no inline comments), so GitHub itself anchors it to the reviewed commit. Keep the issue-comment fallback for unpinned reviews.

Activity

  1. added a commit that references this issue on Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions