Skip to content

Pinned review fallback: body-only review on the same commit (#569) - #570

Merged
renmengye merged 1 commit into
mainfrom
fix/pinned-fallback-review
Oct 23, 2026
Merged

renmengye merged 1 commit into
mainfrom
fix/pinned-fallback-review

Conversation

@renmengye

Copy link
Copy Markdown
Member

Closes #569. When a review pinned to the labeled head is refused (usually its inline anchors), post_round_review used to re-read the head and post the full findings as an issue comment. Issue comments carry no commit, so a push between that read and the post put old findings on the new head. Now the fallback is a body-only review with the same commit_id; if GitHub refuses that too (the commit left the PR), nothing is posted. Unpinned reviews keep the issue-comment fallback.

Tests: the head-moved test becomes two (body-only pinned fallback; both refused -> nothing posted). Full gate passes.

Written by Claude (Opus 5.5); reviewed by codex (no findings).

@renmengye renmengye added the outerloop:review re-request the advisory review label Oct 23, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 1 — reviewed head 28d17d4b — reviewer hermes/gpt-5.6-terra.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: no defects found.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 2 (re-run on the same head) — reviewed head 28d17d4b — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: no defects found.

No findings were submitted by any review lens. Rejected findings: none.

@renmengye
renmengye merged commit 26b745d into main Oct 23, 2026
20 checks passed
@renmengye
renmengye deleted the fix/pinned-fallback-review branch October 23, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

outerloop:review re-request the advisory review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pinned advisory review: fall back to a body-only review on the same commit, not an issue comment

1 participant