Skip to content

BENCHMARKS.md: — for an unimproved baseline row, not "provenance unknown" - #571

Merged
renmengye merged 3 commits into
mainfrom
fix/baseline-row-provenance
Oct 23, 2026
Merged

renmengye merged 3 commits into
mainfrom
fix/baseline-row-provenance

Conversation

@renmengye

Copy link
Copy Markdown
Member

On a freshly seeded repository (the quickstart, for one) every row of BENCHMARKS.md said "provenance unknown" in the main-commit column, which reads like a fault on the first page a new user sees. A row with no main commit whose best is still its baseline now shows —, matching its progress column. Imported and self-reported rows are unchanged.

Seen in a live local-forge run of the quickstart on 0.5.0. One test line added; full gate passes.

Written by Claude (Opus 5.5); reviewed by codex (no findings).

@renmengye renmengye added the outerloop:review re-request the advisory review label Oct 23, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 1 — reviewed head fc213351 — reviewer hermes/gpt-5.6-terra.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: no defects found.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 2 (re-run on the same head) — reviewed head fc213351 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: 1 blocking, 2 advisory.

3 findings attached to the lines below.

Two substantive display regressions: imported baseline rows lose the required provenance-unknown label (blocking), and self-reported baseline rows are changed despite their stated exception. Rejected: none; the general and lifecycle imported-row findings were merged as the same claim, while the prose rewrite is retained separately as required.

Comment thread src/outerloop/progress.py Resolved
Comment thread src/outerloop/progress.py Resolved
Comment thread src/outerloop/progress.py Resolved
@renmengye renmengye added outerloop:review re-request the advisory review and removed outerloop:review re-request the advisory review labels Oct 23, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 3 — reviewed head bbb01b0c — reviewer hermes/gpt-5.6-terra.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: no defects found.

@renmengye
renmengye merged commit 0ef6f18 into main Oct 23, 2026
5 checks passed
@renmengye
renmengye deleted the fix/baseline-row-provenance branch October 23, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

outerloop:review re-request the advisory review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant