Skip to content

Streamline attempt review tests (#497) - #576

Merged
renmengye merged 2 commits into
mainfrom
maint/tests-attempt-review
Oct 24, 2026
Merged

renmengye merged 2 commits into
mainfrom
maint/tests-attempt-review

Conversation

@renmengye

Copy link
Copy Markdown
Member

Next slice of #497, after #567: tests/test_attempt_review.py only, no src/ change.

  • 81 → 74 tests; 178 lines changed, net −30.
  • Merged parameter grids that exercised the same branches (submit/verdict, scope, folded base: one case per distinct branch; the folded-base ledger edit stays covered by the moved-again test).
  • Shared setup for publishing and staged syscalls; assertions that pinned prompt wording or retry counts on the way to another subject now check the behaviour under test.
  • Coverage of src/outerloop/attempt.py from this file is unchanged: 2224 statements, 1301 missed, before and after (uv run --with pytest-cov pytest -n0 tests/test_attempt_review.py --cov=outerloop.attempt).

Built by codex; reviewed by Claude.

@renmengye renmengye added the outerloop:review re-request the advisory review label Oct 24, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 1 — reviewed head 3a66001b — reviewer hermes/gpt-5.6-terra.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: no defects found.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 2 (re-run on the same head) — reviewed head 3a66001b — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: no defects found.

No findings were proposed by any review lens; no findings were merged or rejected.

@renmengye
renmengye merged commit 29d5f75 into main Oct 24, 2026
1 check passed
@renmengye
renmengye deleted the maint/tests-attempt-review branch October 24, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

outerloop:review re-request the advisory review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant