Skip to content

Streamline tests/test_climbboard.py and tests/test_inbox.py (#497 slice) - #589

Merged
renmengye merged 2 commits into
mainfrom
maint/tests-climbboard-inbox
Oct 24, 2026
Merged

renmengye merged 2 commits into
mainfrom
maint/tests-climbboard-inbox

Conversation

@renmengye

@renmengye renmengye commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Next slice of #497: tests/test_climbboard.py and tests/test_inbox.py only, no src/ change.

file tests module missed statements
test_climbboard.py 51 → 45 outerloop.climbboard 35 → 35
test_inbox.py 90 → 84 outerloop.inbox 53 → 53
  • climbboard: the board-JSON outage cases, quota cases, the agent ceiling, garbage-point parsing, the vanished eval dir and the review hypothesis are each folded into the test that covers the same path. An exact setInterval(...) text check is replaced by the property: refresh and re-render exist.
  • inbox: the reply-reference pair, legacy-envelope defaults, the kernel-fence cases and the human-without-association header case are merged. main is dropped from the base-moved advice cases (same plain-ref path as release/next). Exact whole-output checks are replaced by the properties under test. I kept base-moved in the fencing cases: it takes message_text's plain path, not gate-verdict's sub-branch.
  • All issue-numbered regression cases and every distinct boundary are kept.

Built by DeepSeek-V4.1-Flash; reviewed by Claude.

@renmengye renmengye added the outerloop:review re-request the advisory review label Oct 24, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 1 — reviewed head 0cca258c — reviewer hermes/gpt-5.6-terra.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: 1 blocking, 0 advisory.

1 finding attached to the lines below.

The live-strip test no longer checks the refresh delays.

Comment thread tests/test_climbboard.py Resolved

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 2 (re-run on the same head) — reviewed head 0cca258c — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: nothing blocking — 2 advisory notes.

2 findings attached to the lines below.

Two advisory findings: the inbox quote test loses kind-specific kernel rendering coverage for base-moved and gate-verdict messages, and the live-strip test no longer fixes its refresh cadence. Rejected findings: none; the credentials and deployment reports were merged because they identify the same test-coverage regression.

Comment thread tests/test_inbox.py Resolved
Comment thread tests/test_climbboard.py Resolved
@renmengye renmengye added outerloop:review re-request the advisory review and removed outerloop:review re-request the advisory review labels Oct 24, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 3 — reviewed head 3c861dd7 — reviewer hermes/gpt-5.6-terra.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: no defects found.

@renmengye
renmengye merged commit 1c29e5b into main Oct 24, 2026
5 checks passed
@renmengye
renmengye deleted the maint/tests-climbboard-inbox branch October 24, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

outerloop:review re-request the advisory review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant