Repository navigation
One artifact-path validator for the kernel and the syscall tool (#337) - #592
Merged
Merged
Conversation
There was a problem hiding this comment.
Round 2 (re-run on the same head) — reviewed head 8d441254 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: nothing blocking — 2 advisory notes.
1 finding attached to the lines below.
Advisory (non-blocking):
- Suggestion: The validator parity test is now tautological. [deployment] The test imports the kernel validator from syscall.py, which now re-exports the CLI function, so a defect in the shared function makes both checks agree and the test still passes. (
tests/test_syscall_cli.py:127; high confidence)
Merged two advisory suggestions: the validator parity test is tautological because both paths share the same implementation, and the new validator docstring should use the supplied plain-language rewrite. Rejected findings: none; the remaining lenses reported no findings.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical items from maintainer digest #337, as the PI decided on that issue.
syscall_cli._rel_path_ok, which the kernel (syscall.py) imports. The import goes this way becausesyscall_cli.pyis copied verbatim into workspaces and must run with no outerloop installed; it stays stdlib-only, andtest_installed_tool_is_standalonestill passes.docsis a dependency group, and the script builds);brief.code_fenceis already imported everywhere);uv.lock);Gate: ruff check, ruff format --check, mypy, pytest (3068 passed, 7 skipped).
Built by DeepSeek-V4.1-Flash; reviewed by Claude.