Skip to content

One artifact-path validator for the kernel and the syscall tool (#337) - #592

Merged
renmengye merged 2 commits into
mainfrom
maint/digest-337
Oct 25, 2026
Merged

renmengye merged 2 commits into
mainfrom
maint/digest-337

Conversation

@renmengye

Copy link
Copy Markdown
Member

Mechanical items from maintainer digest #337, as the PI decided on that issue.

  • The artifact-path rule now has one implementation, syscall_cli._rel_path_ok, which the kernel (syscall.py) imports. The import goes this way because syscall_cli.py is copied verbatim into workspaces and must run with no outerloop installed; it stays stdlib-only, and test_installed_tool_is_standalone still passes.
  • Already done on main since the digest's Oct 19 scan, so no change:
    • the docs build script (docs is a dependency group, and the script builds);
    • the roles design note;
    • the shared fence helper (brief.code_fence is already imported everywhere);
    • the ruff pre-commit pin (it matches uv.lock);
    • pydantic (already at the latest patch).
  • Left for the maintainer, because they edit workflow files: bridge compatibility tests in CI, and the setup-uv bump.

Gate: ruff check, ruff format --check, mypy, pytest (3068 passed, 7 skipped).

Built by DeepSeek-V4.1-Flash; reviewed by Claude.

@renmengye renmengye added the outerloop:review re-request the advisory review label Oct 25, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 1 — reviewed head 8d441254 — reviewer hermes/gpt-5.6-terra.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: no defects found.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 2 (re-run on the same head) — reviewed head 8d441254 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: nothing blocking — 2 advisory notes.

1 finding attached to the lines below.

Advisory (non-blocking):

  • Suggestion: The validator parity test is now tautological. [deployment] The test imports the kernel validator from syscall.py, which now re-exports the CLI function, so a defect in the shared function makes both checks agree and the test still passes. (tests/test_syscall_cli.py:127; high confidence)

Merged two advisory suggestions: the validator parity test is tautological because both paths share the same implementation, and the new validator docstring should use the supplied plain-language rewrite. Rejected findings: none; the remaining lenses reported no findings.

Comment thread src/outerloop/syscall_cli.py Resolved
@renmengye renmengye added outerloop:review re-request the advisory review and removed outerloop:review re-request the advisory review labels Oct 25, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 3 — reviewed head 834f5871 — reviewer hermes/gpt-5.6-terra.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: no defects found.

@renmengye
renmengye merged commit 021d59b into main Oct 25, 2026
5 checks passed
@renmengye
renmengye deleted the maint/digest-337 branch October 25, 2026 02:56
@renmengye renmengye mentioned this pull request Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

outerloop:review re-request the advisory review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant