Repository navigation
Trajectory step 4: report-only number check in the PR body - #594
Conversation
There was a problem hiding this comment.
Round 1 — reviewed head f212b597 — reviewer hermes/gpt-5.6-terra.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: 1 blocking, 0 advisory.
1 finding attached to the lines below.
The number-check section can exceed the bounded PR body.
There was a problem hiding this comment.
Round 2 (re-run on the same head) — reviewed head f212b597 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: 1 blocking, 5 advisory.
6 findings attached to the lines below.
Merged verdict: one blocking redaction leak and five correctness/coverage findings. Rejected: none; the secret-leak and spaced-percentage reports were duplicates merged across agreeing lenses. The prose-lens secret finding was recorded as a suggestion and its detail retained verbatim as required.
…dles scientific notation, spaced percentages and zero gaps
There was a problem hiding this comment.
Round 3 — reviewed head c46a11a4 — reviewer hermes/gpt-5.6-terra.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: nothing blocking — 1 advisory note.
1 finding attached to the lines below.
The number check does not skip decimal values on seed lines.
|
e4b0260 narrows the skips after the PI's review of a demo. Only seeds ("seed 8271", "seeds 3, 4") and #123 references are skipped now. Small integers, years and percentages are checked, and percentages match the relative gap between measurements. The demo had shown that skipping every integer on a line mentioning a seed hid an invented integer step count. |
There was a problem hiding this comment.
Round 4 — reviewed head e4b02602 — reviewer hermes/gpt-5.6-terra.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: nothing blocking — 2 advisory notes.
2 findings attached to the lines below.
The number check misses an Oxford-comma seed and accepts gaps assembled from unrelated measurements.
Trajectory step 4: a report-only check that numbers in the author's report were measured. Stacked on #593; GitHub retargets it to main once #593 merges.
src/outerloop/number_check.pyis pure: no I/O and no events.#123reference. Small integers, years and percentages are checked: the check is report-only, so a rare false flag is cheaper than hiding a claim.measureevent's baseline or candidate);## Number checklisting unmatched values, marked "Report-only; nothing was blocked". The section is omitted when everything matches.Gate: ruff check, ruff format --check, mypy, pytest (3079 passed, 7 skipped).
Built by DeepSeek-V4.1-Flash, with improvement-gap and sign matching added by Claude; reviewed by Claude.