Repository navigation
Review fork PRs when a maintainer applies the review label - #599
Merged
Merged
Conversation
There was a problem hiding this comment.
Round 1 — reviewed head ef509a21 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: 1 blocking, 0 advisory.
1 finding attached to the lines below.
Blocking: the fork-review opt-in exposes the reviewer credential to untrusted prompt data. Rejected findings: none.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The label-triggered review round now covers PRs from forks.
advisory-review-agent.ymlruns a review session for a fork PR only when the caller passesallow_labeled_forks: trueand the trigger is a label being applied. This repo'sreview.ymlnever passed it, so a fork PR got no review even after a maintainer addedouterloop:review(seen on #598: the session and post jobs were skipped).reviewjob (the label round) opts in. The wide first round on open stays same-repo only, so a fork PR is reviewed only when a maintainer asks.reviewer_refstays atmain, which is newer than the 0.5.1 minimum the opt-in needs.pull_request_targetruns the base branch's workflow, so this takes effect once merged.Verification: the full gate passes (ruff, format, mypy, pytest: 3082 passed, 7 skipped) and pre-commit is clean on the file. No test covers this workflow input; the check is #598 once it is relabeled after merge.
Compatibility: CI configuration only. No kernel state changes.
Built by Claude (Opus 5.5); reviewed by the advisory review bot.