Skip to content

AOT: files that a load has made, symbols behind loops, mocks in test runs, and smaller fixes - #1067

Merged
Jarred-Sumner merged 25 commits into
mainfrom
claude/aot-test-runs-and-module-loads
Nov 16, 2026
Merged

Jarred-Sumner merged 25 commits into
mainfrom
claude/aot-test-runs-and-module-loads

Conversation

@Jarred-Sumner

@Jarred-Sumner Jarred-Sumner commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes of the ahead-of-time compiler (experimental) behind #1064. The programs and test runs are in oven-sh/bun#49108.

What it was What it is now
While a load goes on, an ES module that is required meanwhile read what a CommonJS file exported when the loader had made its record, where the record was not stored yet. It reads what is exported by then (AOTModuleEvaluation.cpp, JSMicrotask.cpp).
A file loaded from disk that imports a member which a built-in module makes when it is first read saw a later store into the module's object. The member is made when the binding is made (AOTModuleLinking.cpp, CyclicModuleRecord.cpp).
Of two or three import() calls at once, a CommonJS file of one graph ran in front of the body of another graph. A file of a graph that is loaded beside another one runs when its text comes.
A generator that a script's time limit ended answered { done: true }. It counts as running.
A symbol made behind a loop and laid on a prototype: the process ended with a check of the compiler. A symbol that a call may make in a loop is no name that the compiler knows (AOTScan.cpp).
A build could stop: while (x < w) { s += g[y * y + x] ?? 0; x++; if (x > 300) break; }, and on arm64 a loop that polls and hands over numbers in turns. It is built (AOTWalkLoopsBuiltTwice.cpp, AOTCodeGenerator.cpp).
A loop that moves the elements of a table which is its own row read elements as another kind. The loop asks for the kinds of elements that its tests allow (AOTCodeGeneratorMoveLoops.cpp).
bun test --aot: a mock of what a CommonJS file requires was seen by the next test file, where an import of the file had settled. A file is kept for pending imports alone.
bun test --aot: a file that is mocked with what it requires ran again in the next test file, depending on the paths. It comes back with it (AOTTestRunMocksLetGo.cpp).
bun test --aot: a file mocked by its original, read while a CommonJS file that has run changes its exports, saw what it exported before. The record takes what the file exports by then.
bun test --aot: importActual() of a file that two mocks of an earlier test file lay over never settled. The record of a file that was released is not evaluated.
bun test --aot: the modules that a failed require() had fetched were left to the next test file. They belong to the test file that fetched them.
bun test --aot: mocks that a hook laid, an unmock() over a file of a preload, and a preload's mock by its original were seen by the next test file. Their entries are told apart (AOTModuleInstances.cpp); the rows are in oven-sh/bun#49108.
A build of the edit distance whose rows are pushed stopped. It is built (AOTWalkListReadsInLoops.cpp).
For an entry that exports what a file outside the build answers, the work of a link grew with the square of what hangs on it. What lies in each layout is visited once (AOTLinkFlow.cpp, AOTLinkReach.cpp).
A program with direct evals was linked by two flows, one after the other. The second takes up the first where it stopped, and finds the same (AOTLink.cpp, AOTLinkReach.cpp, AOTFacts.cpp).
The compiler's own check that its types have reached a fixed point (FlowFixpoint) failed on some programs at getters and at counts. No wrong answer is known. They reach it.

A commit for each row or two. Two commits have no row: checks of the link, the machine code and the types are compiled for size, and a link to a file whose mock is still waiting is to the file's last instance.

If you don't use --aot

  • JSMicrotask.cpp: the loader asks a module for its class when its record is made and when it is stored. For each module that a plain program makes, runModuleRegistryFetchSettled() takes 60 instructions on x64 and 62 on arm64 (it took 50 and 53), and runModuleRegistryModuleSettled() 58 and 66 (48 and 49).
  • CyclicModuleRecord.cpp: what a binding of a compiled module is made of is recorded behind hasCompiledCode(). A named import takes 61.2 instructions on x64 and 55.8 on arm64 (it took 62.8 and 61.0); the rest of initializeEnvironment() is the same.
  • Nothing else outside Source/JavaScriptCore/aot/ changes.

What was read

The native tests pass on Linux x64 (2,180) and arm64 (2,162), and so do 2,865 tests of the IR on both. Of the engine's tests 574 pass on arm64 and 576 on x64, where five fail that fail without the changes too. The test runs and programs of the changes print what plain Bun prints: on Linux x64 40 of 40, in both orders, by default, in random order, and rerun, and on arm64 all 44 of a text that held two forms more.

Known issues

  • The compiler's own check that its types have reached a fixed point (FlowFixpoint) fails on a few large bundles, as on main. No wrong answer is known.

…by then

While a load goes on, the loader makes the records of the files that a module requests before it
stores them in the registry. An ES module that is required meanwhile read what such a CommonJS file
exported when its record was made.
…t is stored

The lines stand under `ENABLE(AOT)`. A module that isn't compiled is asked for its class once when
its record is made and once when it is stored. Instructions a call, once for each module made:

- runModuleRegistryFetchSettled(): 50 before, 60 now on x64; 53 before, 62 now on arm64.
- runModuleRegistryModuleSettled(): 48 before, 58 now on x64; 49 before, 66 now on arm64.
…made when it is bound

A file that is loaded from disk and imports such a member saw a later store into the module's
object.
…CompiledCode()

A process without compiled code asks one byte where it asked the class of the module. Instructions
of `initializeEnvironment()` in plain Bun: 319 on x64 and 307 on arm64, as before; a named import
takes 62.8 before, 61.2 now on x64, and 61.0 before, 55.8 now on arm64.
…ounts

The compiler's own check of that failed on some programs. No wrong answer is known.

- A getter whose other objects aren't in sight is called by unseen code.
- The message of the check says what its shadows are.
Whether a CommonJS file may be released at the end of a test file asked for the last import() of
it, settled or not, so a mock of what the file requires was seen by the test file behind it. Only a
pending import keeps it.
A program with direct evals was linked by two flows, one after the other: one without what its
evals show, and one with it. The second takes up the first one where it stopped. What the link finds
is the same.
…at the file exports by then

For a file that is mocked by its original, and that is read while it changes its exports.
The mocks of a test file end in no order. The end of one brought a file back, and the end of another
released it, so the next test file ran it again, depending on the paths.
…ts tests allow

A table that is its own row, or that stands in itself twice, was moved as if its rows were numbers.
An array of int32s holds no rows, so a store into it leaves them as they are.
… evaluated

The promise of importActual() of a file that two mocks of an earlier test file lay over never
settled.
…s when its text comes

Of two or three import() calls at once, a CommonJS file of one graph ran in front of the body of
another graph.
It answered `{ done: true }`. What a termination has left is not complete.
For the host, which tells the mocks that hooks lay from those of the preload file.
For what vi.doUnmock() does over a CommonJS file that a preload ran.
On arm64 the build of a loop that polls and whose numbers are handed over in turns could stop.
Neither way dominates the other.
… what the front has proven

`while (x < w) { s += g[y * y + x] ?? 0; x++; if (x > 300) break; }` stopped a build.
…for size

They only look at what the compiler has made. The compiler is smaller by about 20 KB.
… file's last instance

A link to that file is written to the instance that the file had before its mock is run, and no
instance is made for it there. Only a file that is in no cycle of imports, or whose factories can
see it, is linked so. Test runs.
…iler knows

`const brand = Symbol("brand")` behind a loop, laid on a prototype with `Object.defineProperty()`:
the process ended with a check of the compiler. A call in a loop makes another symbol each time, and
which blocks are in loops is known after the scan.
…e test file

The loader keeps the modules of the graph that it was loading.
…es leaves with its original

What a run with resets reads by a statement. Who asks for one of its importers next is told.
The types of thousands of nodes may name the same layouts, and what lies in each is visited where it
is named first. For an entry that exports what a file outside the build answers, the work of a link
grew with the square of what hangs on it: 9.8, 11.4, and 17.1 billion instructions of a build beside
250, 500, and 1,000 modules, now 9.4, 9.8, and 10.7 (arm64).
…st for an array

Builds of the edit distance whose rows are pushed stopped.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. Because it is 24 commits across the AOT link/flow analysis, the module loader's mock and release bookkeeping, and two shared runtime paths, a human look would still be worthwhile.

What was reviewed:

  • Shared runtime touch points: the new code in CyclicModuleRecord.cpp and JSMicrotask.cpp stays inside #if ENABLE(AOT) and keeps existing BUN_JSC_ADDITIONS nesting; the made-and-not-stored flag is set only when the make-module promise already fulfilled with the same record and is cleared again in runModuleRegistryModuleSettled.
  • Link changes: each #pragma clang attribute push(minsize) has a matching pop in the same file (AOTLink, AOTLinkFlow, AOTBodyVerifierFlow, AOTMachineValidate, AOTWalkGuesses); forEachContainedNode's new signature has a single caller; FunctionsThatEvaluate/LinkBeforeEvaluation do not collide with other names in aot/; the second linkBeforeEvaluation call passes an empty split so its tables is always present.
  • AOTScan::mayLieInLoop suffix-min and the MoveLoop kinds-allowed check were read for index bounds and consistency with the emitter; the generator change now leaves state untouched only for termination exceptions.
  • Not done by this review: running Tools/Scripts/aot/check-unified-sources.py and building with ENABLE_AOT=0 and =1.
Extended reasoning...

The change is 608 insertions across 28 C++ files, almost all in the experimental AOT compiler (link/flow analysis, codegen loop handling, module instance and mock bookkeeping for bun test) plus two guarded additions to the shared module loader and module record linking. It touches no auth, crypto, injection, or data-exposure surface. The diff is internally consistent (pragma pairs, signatures, guards) and the bug-hunting rounds found nothing, but the size, the number of interacting state flags in the module runtime, and the absence of tests in the diff mean confidence rests on the author's reported test runs rather than anything verifiable here, which decided defer over approve.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The PR changes AOT direct-eval analysis, module loading and mock handling, and loop and code-generation checks. It also updates object-construction paths, bytecode-generator exception state, and Clang function-size attributes.

Changes

AOT direct-eval and link-flow analysis

Layer / File(s) Summary
Direct-eval records and link contracts
Source/JavaScriptCore/aot/facts/AOTBuiltinsInReach.h, Source/JavaScriptCore/aot/facts/AOTFactsOfProgram.cpp, Source/JavaScriptCore/aot/facts/AOTLinkFlow.h, Source/JavaScriptCore/aot/facts/AOTLinkReach.cpp
Direct-eval findings can be retained for later admission. Link-flow and program-fact APIs add the supporting declarations and state.
Pre-evaluation linking and flow traversal
Source/JavaScriptCore/aot/facts/AOTFacts.cpp, Source/JavaScriptCore/aot/facts/AOTLink.cpp, Source/JavaScriptCore/aot/facts/AOTLinkFlow.cpp, Source/JavaScriptCore/aot/facts/AOTLinkFlow.h, Source/JavaScriptCore/aot/facts/AOTLinkAccesses.cpp, Source/JavaScriptCore/aot/facts/AOTLinkCalls.cpp
Before-evaluation fact collection can return a continued flow. Linking tracks function reach constraints and visited containers. Link access and getter handling also change.
Direct-eval admission and reachability
Source/JavaScriptCore/aot/facts/AOTLinkReach.cpp
Reachability processing admits deferred evaluations, updates variable initial-value handling, and uses visited-container traversal for exported builtins.

AOT module loading and test mocks

Layer / File(s) Summary
Deferred export capture and binding reads
Source/JavaScriptCore/aot/runtime/AOTModuleLinking.cpp, Source/JavaScriptCore/aot/runtime/AOTModuleRecord.h, Source/JavaScriptCore/aot/runtime/AOTModules.cpp, Source/JavaScriptCore/aot/runtime/AOTModules.h, Source/JavaScriptCore/runtime/CyclicModuleRecord.cpp
Module linking records deferred export names. Compiled import binding initialization can read eligible deferred exports from builtin modules.
Fetch state and module evaluation
Source/JavaScriptCore/aot/runtime/AOTModuleEvaluation.cpp, Source/JavaScriptCore/aot/runtime/AOTModuleRecord.h, Source/JavaScriptCore/aot/runtime/AOTModules.cpp, Source/JavaScriptCore/aot/runtime/AOTModules.h, Source/JavaScriptCore/runtime/JSMicrotask.cpp
Module records track made-but-not-stored state. Fetch settlement, synchronous load transfer, facade evaluation, and export recapture use the added state and helpers.
Mock instances and test-file release
Source/JavaScriptCore/aot/runtime/AOTModuleEvaluation.cpp, Source/JavaScriptCore/aot/runtime/AOTModuleHost.h, Source/JavaScriptCore/aot/runtime/AOTModuleInstances.cpp, Source/JavaScriptCore/aot/runtime/AOTModules.cpp, Source/JavaScriptCore/aot/runtime/AOTModules.h, Source/JavaScriptCore/aot/runtime/AOTTestRunMocksLetGo.cpp
Linking can use an instance from before a pending mock. Import release checks, failed-load tracking, actual-key checks, and test-file release APIs change.

AOT loop and code-generation checks

Layer / File(s) Summary
Move-loop storage constraints
Source/JavaScriptCore/aot/codegen/AOTCodeGeneratorMoveLoops.cpp
Move-loop analysis intersects storage-kind constraints across array groups, validates element uses, and emits guards for allowed kinds.
Loop scanning and versioning checks
Source/JavaScriptCore/aot/facts/AOTScan.cpp, Source/JavaScriptCore/aot/walk/AOTWalkListReadsInLoops.cpp, Source/JavaScriptCore/aot/walk/AOTWalkLoopsBuiltTwice.cpp
Symbol keys are rejected when their defining calls may lie in loops. Loop-versioning cleanup tracks front-of-loop proofs, and invariant array reads reject empty holders.
Construction completion and reachability
Source/JavaScriptCore/aot/walk/AOTWalkBirthsListed.cpp, Source/JavaScriptCore/aot/walk/AOTWalkCalls.cpp, Source/JavaScriptCore/aot/walk/AOTWalkEntries.cpp
Construction-state reporting now occurs on applicable object-return paths. Constructor handling checks reachability before reporting completed objects, binding results, or joining paths.
Generator and code-generation state
Source/JavaScriptCore/aot/builtins/AOTEngineIntrinsicOperations.cpp, Source/JavaScriptCore/aot/codegen/AOTCodeGenerator.cpp
Termination exceptions leave bytecode-generator state unchanged. Loop handover restores the saved integer-number vector size.
Clang function-size attributes
Source/JavaScriptCore/aot/facts/AOTLink.cpp, Source/JavaScriptCore/aot/facts/AOTLinkFlow.cpp, Source/JavaScriptCore/aot/ir/AOTBodyVerifierFlow.cpp, Source/JavaScriptCore/aot/machine/AOTMachineValidate.cpp, Source/JavaScriptCore/aot/walk/AOTWalkGuesses.cpp
Clang builds apply minsize attributes to the listed AOT functions.

Possibly related PRs

  • oven-sh/WebKit#1064: The PR description identifies #1064 as the AOT change this work builds on; both cover the AOT compiler and module-loading subsystem.
  • oven-sh/WebKit#1061: Both PRs change AOT CommonJS mock and module-loading behavior and loop-related analysis.
Merge Risk: Minimal · up to 12f51

The change adjusts experimental ahead-of-time compiler analysis and module loading behavior. No concrete merge-blocking risk was identified in the supplied material.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title lists several themes (module load timing, loop symbols, test-run mocks, smaller fixes) that do appear in the changeset. It does not name one primary change, and the title is long (17 words).…
Description check Passed The description follows the WebKit-style structure only loosely. It has no bug link, no 'Reviewed by' line, and no ChangeLog-style file list with function names, which the template requires. It does e…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title lists several themes (module load timing, loop symbols, test-run mocks, smaller fixes) that do appear in the changeset. It does not name one primary change, and the title is long (17 words). The title is partially related: it refers to real parts of the change but is overly broad and does not state the main point.

Full details: Description check

Explanation

The description follows the WebKit-style structure only loosely. It has no bug link, no 'Reviewed by' line, and no ChangeLog-style file list with function names, which the template requires. It does explain what changed and what was tested, with a table of fixes, a non-AOT impact section, test results, and known issues. Most of the substance is present, so the description is mostly complete even though the template's required bug and file-list items are missing.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

The configuration directory could not be loaded. This review used the available YAML and UI settings; directory instructions and checks were not evaluated.

Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use path_filters to narrow the review scope.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5b8ce8e7-d5af-46ef-ac9c-d836d179a53f
Commits

Reviewing files that changed from the base of the PR and between 24a7d37 and 12f515c.

Files selected for processing: 3

  • Source/JavaScriptCore/aot/walk/AOTWalkBirthsListed.cpp
  • Source/JavaScriptCore/aot/walk/AOTWalkCalls.cpp
  • Source/JavaScriptCore/aot/walk/AOTWalkEntries.cpp

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Preview build of 12f515c: autobuild-preview-pr-1067-12f515c5

… the object that was made

A constructor function that gives another object in front of its own stores, as with `return new
Other()`: the process ended with a check of the compiler. The object that was made is dropped there,
and nobody sees it.

- The check stands in the arm that gives the object that was made: in the direct call, in the copy
  of the body, and in the entry from unknown code.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

Jarred-Sumner added a commit to oven-sh/bun that referenced this pull request Nov 16, 2026
- `autobuild-preview-pr-1067-12f515c5` is built from 12f515c583d19f52512e626a1a54f54ea4b66ab4, the
  head of the pull request.
@Jarred-Sumner
Jarred-Sumner merged commit ae8978d into main Nov 16, 2026
88 checks passed
Jarred-Sumner added a commit to oven-sh/bun that referenced this pull request Nov 16, 2026
- `ae8978d0331bfce97259b446378265eb327c407a` is oven-sh/WebKit#1067 on WebKit's main. Its tree is that
  of the preview that the branch pinned.
Jarred-Sumner added a commit to oven-sh/bun that referenced this pull request Nov 16, 2026
- `ae8978d0331bfce97259b446378265eb327c407a` is oven-sh/WebKit#1067 on WebKit's main. Its tree is that
  of the preview that the branch pinned.
Jarred-Sumner added a commit to oven-sh/bun that referenced this pull request Nov 16, 2026
…s of the engine's fixes (#49108)

Bun's side of fixes of the ahead-of-time compiler (`bun build --compile --aot` and `bun test
--aot`, both experimental), with the programs and test runs of the engine's. The JavaScriptCore
side is merged: oven-sh/WebKit#1067, which is `ae8978d0331bfce97259b446378265eb327c407a`. This
follows #49081.

378 files, +2,351 -335: src 23 files, +414 -93; the pin; docs; test 353 files, +1,933 -239.

Programs and types

- `--aot-allow-code-from-disk` builds a file that names an evaluator only to test it.
- `eval("import('./a.js')")` and `new Function("return import('./a.js')")`: the replacement of
  `eval` or `Function` is called where the build can see that the program puts one in place, also by
  `Object.assign()` and `Reflect.set()`. Elsewhere the call throws an `EvalError`. The docs say it.
- A member of an enum of another file is read off the enum where the program stores into it
  through a load of one of several files.

Test runs

- A CommonJS file that a preload ran stays loaded under two mocks of a test file, and the original
  that the test asks for behind them is a run of its own. An ES file of a preload that a mock
  couldn't release is run again for its original.
- A hook's uncalled mock doesn't come back for the next test file.
- A test's `vi.doMock()` of a file that a preload mocks by its original loads the file again, also
  behind a first file that only resets. In a run with resets, such a mock is taken out with its
  original.
- Where `bun test` runs a file again, `vi.doUnmock()` over a CommonJS file of a preload and a
  required mock with an async factory say so.

Order files

- `compile.aotOrder` given as a getter is asked once.

Tests

- Files that are made and not stored while a load goes on, files from disk that import what a
  built-in module makes when it is first read, files of graphs that are imported at once,
  generators that a time limit ends, tables that are their own rows, loops that hand over numbers
  in turns, loops whose keys are sums of squares, symbols made behind a loop, mocks that end
  together, `importActual()` of a file that two mocks lay over, modules of requires that failed,
  rows of an edit distance that are pushed, and rows that name each other in a list that the entry
  exports.
- Constructor functions that give another object.
- The test of a region that a pool's thread starts has a pool of its own, and waits with a deadline.
- The durations of the tests under AddressSanitizer are the measured ones.

Known: the compiler's own check that its types have reached a fixed point fails on a few large
bundles, as on main.
robobun added a commit that referenced this pull request Nov 16, 2026
main has #1067 (AOT). No file conflicts. Six files change on both sides: aot/runtime/AOTModuleEvaluation.cpp,
AOTModuleInstances.cpp, AOTModules.cpp, AOTModules.h, runtime/CyclicModuleRecord.cpp and runtime/JSMicrotask.cpp.

#1067 notes which CommonJS files a load has made and not yet stored (setIsMadeAndNotStored()): in
runModuleRegistryFetchSettled(), in runModuleRegistryModuleSettled() and behind the steps that
transferSynchronousLoad() runs. That is bookkeeping of the record and runs no code of the program. It also reads
a deferred export of a built-in module where a binding is linked (readDeferredExportForBinding()), inside the
job of the load. #1067 adds no job of the module loader, no call of import() that is made again and no place
that hands the async context of a load on.

The lines that this branch changes against main are the same as before the merge.

ae8978d is #1067 as merged. Bun's main pins it (oven-sh/bun#49108).
robobun added a commit to oven-sh/bun that referenced this pull request Nov 16, 2026
main has #49108: its pin is ae8978d033, which is oven-sh/WebKit#1067 as merged. WEBKIT_VERSION is now the
preview build of the head of oven-sh/WebKit#941 (0d50be2a58), which is ae8978d033 with the change.

Conflicts: the pin, and test/parallel-allowlist.json, where main and this branch each add entries at the end
of the list. All three entries stay.
Jarred-Sumner added a commit that referenced this pull request Nov 17, 2026
…ong views, and smaller fixes (#1069)

Fixes of Bun's ahead-of-time compiler (`bun build --compile --aot` and `bun test --aot`, both
experimental). Bun's side is oven-sh/bun#49145, which pins this one. This follows
#1067.

22 files, +213 -65: 14 in Source/JavaScriptCore/aot/ (+176 -30) and 8 outside it.

Programs

- A name that a program was found not to have on a short typed array (`4294967295`) was taken for
  one that a view of 4,294,967,296 elements doesn't have either. It is asked of the view.
- Code that is made at run time and stores to a constant of a script throws, as in plain Bun.
- `for..of` over an object whose `[Symbol.iterator]()` hands back an iterator of a collection that
  code has laid a `return()` or a `next()` on, kept or stepped, calls the iterator's own.

Test runs

- Code from source beside a preload's mock whose entry a reset has removed asks for the entry again.
- An import under another file's patch and a file that threw in an earlier test file are told apart
  from what they were taken for.
- A `require()` under a second patch that waits is told of.

Builds

- A build that stopped under `--aot-harden=proof-checks` is built: where the name that a check asks
  about is handed on at the head of a loop, at a join or at a call that was copied, and where
  something stands between a branch and what it narrowed. One that stopped under
  `--aot-check=VerifyEachStage` is built too.

If you don't use `--aot`

- The loader asks whether a process has compiled code in front of a module's class. A fresh module
  takes 17 instructions fewer of 145,683 on x64 and 55 of 142,515 on arm64, one that imports 44 and
  194 fewer. innerModuleLinking() and innerModuleEvaluation() take three to eleven more.
- A store of code made at run time into a global variable takes 66 instructions on x64, as before,
  and 63.5 on arm64 (it took 61.5).

Known: the compiler's own check that its types have reached a fixed point fails on a few large
bundles, as on main. No wrong answer is known.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant