Skip to content

Repos for Organization Duplication #34

Description

@bdejban

I'm seeing an issue with the following method:

- (void)repositoriesForOrganization:(NSString *)organization success:(UAGithubEngineSuccessBlock)successBlock failure:(UAGithubEngineFailureBlock)failureBlock;

When used in a for loop, passing organizations 1-by-1, the response array seems to concatenate the previous organization's repos to this list, as if the internal mutable array isn't clearing before each request.

What's happening is the self.multiPageArray isn't resetting between requests, and the only logic that initializes the multiPageArray to 0 items is in the init method of the engine itself.

self.multiPageArray = [@[] mutableCopy];

Does this mean we need to init the engine before each request?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions