fix: [OCISDEV-1435] resolve vault permanent links opened outside the vault - #12989
Closed
gauravsoni119 wants to merge 1 commit into
Closed
gauravsoni119 wants to merge 1 commit into
gauravsoni119 wants to merge 1 commit into
Conversation
gauravsoni119
force-pushed
the
fix/ocisdev-1435-vault-permalink-outside-vault
branch
from
September 23, 2026 09:36
a9a75e0 to
ffad200
Compare
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Author
|
Will do in another PR in reva. |
gauravsoni119
deleted the
fix/ocisdev-1435-vault-permalink-outside-vault
branch
September 23, 2026 09:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A permanent link copied inside the Safe is
<server>/f/<fileId>without/vault, so it opens in a normal Drive tab. The redirect added in #12881 detects vault files by comparing against thevault_storage_providercapability, but that value was only sent oncapabilities?vault=true. A Drive tab got"", the redirect never fired, and the user saw "An error occurred while resolving the private link".Fix is in reva: the provider id is now part of every capabilities response when vault mode is enabled. This also fixes vault notifications showing in the Drive view and the invite form not recognizing vault resources. No frontend change needed. The vendor change mirrors the reva PR.
Tests: new reva unit tests; new acceptance scenario in
apiVault/vault.featurechecking the plain capabilities endpoint returns the id (needs vault CI). Verified manually on a local ocis_full vault deployment.