Skip to content

fix: [OCISDEV-1435] resolve vault permanent links opened outside the vault - #12989

Closed
gauravsoni119 wants to merge 1 commit into
masterfrom
fix/ocisdev-1435-vault-permalink-outside-vault
Closed

gauravsoni119 wants to merge 1 commit into
masterfrom
fix/ocisdev-1435-vault-permalink-outside-vault

Conversation

@gauravsoni119

Copy link
Copy Markdown
Contributor

A permanent link copied inside the Safe is <server>/f/<fileId> without /vault, so it opens in a normal Drive tab. The redirect added in #12881 detects vault files by comparing against the vault_storage_provider capability, but that value was only sent on capabilities?vault=true. A Drive tab got "", the redirect never fired, and the user saw "An error occurred while resolving the private link".

Fix is in reva: the provider id is now part of every capabilities response when vault mode is enabled. This also fixes vault notifications showing in the Drive view and the invite form not recognizing vault resources. No frontend change needed. The vendor change mirrors the reva PR.

Tests: new reva unit tests; new acceptance scenario in apiVault/vault.feature checking the plain capabilities endpoint returns the id (needs vault CI). Verified manually on a local ocis_full vault deployment.

@gauravsoni119
gauravsoni119 requested a review from a team as a code owner September 23, 2026 09:36
@gauravsoni119
gauravsoni119 force-pushed the fix/ocisdev-1435-vault-permalink-outside-vault branch from a9a75e0 to ffad200 Compare September 23, 2026 09:36
@kw-security

kw-security commented Sep 23, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gauravsoni119

Copy link
Copy Markdown
Contributor Author

Will do in another PR in reva.

@gauravsoni119
gauravsoni119 deleted the fix/ocisdev-1435-vault-permalink-outside-vault branch September 23, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants