fix: map ErrNotExist to NotFound in RestoreRecycleItem - #740
Merged
Merged
Conversation
Restoring a trash item whose trash-symlink no longer exists (already restored or purged) returned a bare *fs.PathError, surfacing as 500 CODE_INTERNAL instead of 404. Mirror PurgeRecycleItem's existing ErrNotExist -> errtypes.NotFound mapping.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
LukasHirt
approved these changes
Sep 17, 2026
Merged
9 tasks
mzner
added a commit
to owncloud/ocis
that referenced
this pull request
Sep 18, 2026
…urns 500 (#12969) fix(deps): bump reva to pull in ErrNotExist->NotFound fix for RestoreRecycleItem Restoring an already-restored/purged trash item returned 500 CODE_INTERNAL instead of 404. Fixed upstream in owncloud/reva#740; bump the vendored reva to 98fec04d9 to pick it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring a trash item whose trash-symlink no longer exists (already restored or purged) returned a bare *fs.PathError, surfacing as 500 CODE_INTERNAL instead of 404. Mirror PurgeRecycleItem's existing ErrNotExist -> errtypes.NotFound mapping.
fixes OCISDEV-1370