[nexus] use matching_classes in alert glob reprocessing - #11078
Merged
Conversation
hawkw
added
nexus
smklein
approved these changes
Aug 13, 2026
| &opctx.log, | ||
| "alert glob matches event class"; | ||
| "rx_id" => ?glob.rx_id, | ||
| "glob" => ?glob.glob.glob, |
This way, the glob reprocessing code and the alert list endpoint use the same underlying logic for matching globs, and it's defined in one place. This should make subsequent changes (such as performance improvements) a bit easier, and ensures that the two will behave identically.
hawkw
force-pushed
the
eliza/alert-glob-refactor
branch
from
August 14, 2026 18:35
18b5a29 to
556a25d
Compare
hawkw
enabled auto-merge (squash)
August 14, 2026 18:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #11072.
This way, the glob reprocessing code and the alert list endpoint use the same underlying logic for matching globs, and it's defined in one place. This should make subsequent changes (such as performance improvements) a bit easier, and ensures that the two will behave identically.