Skip to content

fix: retain newer outgoing delivery status from history - #259

Merged
jlucaso1 merged 2 commits into
mainfrom
fix/history-delivery-evidence
Oct 27, 2026
Merged

jlucaso1 merged 2 commits into
mainfrom
fix/history-delivery-evidence

Conversation

@jlucaso1

@jlucaso1 jlucaso1 commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

An outgoing message already stored as server-acknowledged ignores a later history copy carrying explicit delivery/read/played status. It therefore keeps one tick after reopening even though that history supplied stronger evidence.

Advance successful outgoing status after account/chat/sender identity resolution, independently of stale history content. The insertion helper now distinguishes explicit WebMessageInfo history status from placeholder defaults, so an undecryptable own-message fanout cannot promote an existing send. Preserve live content, terminal failures, revoked rows and newer states. Server ACK alone remains Sent; this does not establish the cause of an incident without receipt/history evidence.

Validation on 2379295: 55 focused store tests passed (6 delivery/reopen/provenance, 7 history, 29 receipt and 13 message/placeholder tests); one existing history benchmark ignored. The newer-history and PN/LID regressions failed before the fix, while ordinary delivery → file-backed DB reopen already passed. The own-placeholder non-promotion regression also failed before the provenance correction. Tests cover direct/group identity, account isolation, older events, failed/incoming collisions and early unowned receipts. Chat-store all-target/all-feature clippy with -D warnings, fmt and diff checks passed. Two unchanged hydration/chat-preview tests and session/GUI lint passed on the initial PR head. Full exact-head workspace/platform validation remains with CI.

All fixtures are synthetic and tests used temporary data roots. No real account, outgoing messages or receipts were exercised. No migrations, external protocol/core changes or separately pending audio follow-up changes.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f55b602b-d418-44b6-a9fd-e563821d1237
Commits

Reviewing files that changed from the base of the PR and between 2110627 and 2379295.

Files selected for processing: 8
  • crates/chat-store/src/store/event.rs
  • crates/chat-store/src/store/history_sync.rs
  • crates/chat-store/src/store/inbound.rs
  • crates/chat-store/src/store/message_rows.rs
  • crates/chat-store/src/store/writer.rs
  • crates/chat-store/tests/delivery_reload.rs
  • crates/gui/src/app/chat_row.rs
  • crates/session/src/whatsapp/convert.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T01:01:27.598306Z 2379295 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 6f0ce42f51

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jlucaso1
jlucaso1 marked this pull request as ready for review October 27, 2026 00:54

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f0ce42f51

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/chat-store/src/store/message_rows.rs Outdated
@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

The PR lets explicit history evidence advance an existing outgoing message’s delivery status without replacing its content.

  • History sync can advance an outgoing message to a newer delivery state.

No new actionable issues were found. Tests were inspected, not run.

Reviews (2) · Last reviewed commit: "fix: require explicit history evidence f..." · Reviewed by Greptile

greptile-apps[bot]
greptile-apps Bot previously approved these changes Oct 27, 2026
@greptile-apps
greptile-apps Bot dismissed their stale review October 27, 2026 01:00

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

@jlucaso1
jlucaso1 merged commit e198fe9 into main Oct 27, 2026
15 checks passed
@jlucaso1
jlucaso1 deleted the fix/history-delivery-evidence branch October 27, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant